Launch unsupported invocations of tsh ssh in local shell #676
Conversation
| // Jest doesn't let us selectively automock classes. See https://github.com/facebook/jest/issues/11995 | ||
| // | ||
| // So instead for now we just mock all classes in the module and then do `jest.requireActual` when | ||
| // we need to have the actual class when writing tests for it. | ||
| jest.mock('./quickPickers'); |
There was a problem hiding this comment.
The problem here is that I want to be able to selectively mock some classes from the imported module. But Jest allows me to either automock all of them or manually mock only selected imports.
Manually mocking stuff is super cumbersome, like cmon, the computer should be able to do it for me. And the solution I chose is wack too but better than manual mocking.
jest-create-mock-instance is one option, it'd make using mocks so much easier and its source code is very short. But idk about adding a package that can theoretically stop us from updating Jest. Jest should really come with something for that OOTB. :(
There was a problem hiding this comment.
Agree, jest-create-mock-instance would block as from upgrading jest, so IMO it is not an option.
I think the solution you selected is not that bad, I'd stay with it for now.
ravicious
force-pushed
the
ravicious/command-bar-tsh-ssh-options
branch
from
afa37af to
93c94d7
Compare
Also removes some leftovers from quick pickers.