This repository has been archived by the owner on Feb 8, 2024. It is now read-only.
Add keyboard support to Connections popover
#651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ravicious
approved these changes
Mar 8, 2022
gzdunek
force-pushed
the
gzdunek/add-connections-keyboard-support
branch
from
09fbf0e to
88baa83
Compare
ravicious
pushed a commit
that referenced
this pull request
Apr 26, 2022
ravicious
added a commit
that referenced
this pull request
Apr 27, 2022
* Add more tests to Teleterm (#601) * add more tests to Teleterm * Update command for generating gRPC files for Teleterm * Add cluster context switching (#624) * Add connections switcher (#647) * Add keyboard support to `Connections` popover (#651) * Add clusters picker (#668) * Improve identity picker (#670) * Reformat commandLauncher.ts * Remove command palette commands from command launcher The way their `run` function works conflicts with the new implementation (it directly changes quickInputService's state), so we remove that in this commit to have less to deal with in upcoming commits. * Show autocomplete suggestions in command bar This commit does not support actually choosing any suggestion yet, just showing them in the UI. * Remove code related to empty command bar item Our new code isn't going to show anything when there are no matches. * Remove old pickers, rename Item to Suggestion * Autocomplete commands and ssh logins * Ignore case for autocomplete * Automatically append @ after ssh login suggestion * QuickInputService.getAutocomplete: Return no-match on empty suggestions This required adding all those mocks to the tests so that the returned suggestions in some of the tests are not empty. * Autocomplete ssh hostnames * Open command bar commands in new local shell * Append space after picking command suggestion * Adjust how showing & hiding autocomplete works in command bar 1. Pressing Esc while suggestions are shown should first close the suggestions and the second press should actually exit the input. 2. Picking a suggestion should close the autocomplete if we didn't append anything to the token (see comment for details). 3. Typing something in the command bar should always show the autocomplete in case there are suggestions to show. Also remove unused call to setInputValue. * Fix opening new terminal when there's no active document * useQuickInput: Rename serviceQuickInput to quickInputService * Include command to run in AutocompleteResult * Create DocumentTshNode after executing "tsh ssh" in command bar * Update teleterm styles (#674) * Remove leftover cruft from quick pickers * Launch unsupported invocations of tsh ssh in local shell * add simple empty state to pickers * adjust `QuickInput` to match designs * always show active item in `QuickInputList` * make middle part of `TopBar` central Co-authored-by: Grzegorz Zdunek <[email protected]> Co-authored-by: Grzegorz Zdunek <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyboardArrowsNavigationhas been implemented usingcontextto allow iterating over the items which are placed on different DOM levels. It will be useful for example inIdentitypopup where on a single list we will haveFilterableListitems and Logout item.