-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Reauthenticate
components to handle generic MFA challenges.
#49680
Open
Joerger
wants to merge
12
commits into
master
Choose a base branch
from
joerger/refactor-reauthenticate
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joerger
force-pushed
the
joerger/unify-mfa-methods
branch
from
December 3, 2024 20:59
0d9623a
to
518f3ef
Compare
Joerger
force-pushed
the
joerger/refactor-reauthenticate
branch
from
December 3, 2024 20:59
9d5b285
to
b4e63c1
Compare
Joerger
force-pushed
the
joerger/unify-mfa-methods
branch
3 times, most recently
from
December 3, 2024 23:40
e2afc8c
to
e53c97c
Compare
Joerger
force-pushed
the
joerger/unify-mfa-methods
branch
from
December 4, 2024 20:46
e53c97c
to
a36af16
Compare
Joerger
force-pushed
the
joerger/refactor-reauthenticate
branch
from
December 4, 2024 21:09
b4e63c1
to
5eca740
Compare
Joerger
force-pushed
the
joerger/unify-mfa-methods
branch
from
December 4, 2024 21:27
a36af16
to
037f575
Compare
Joerger
force-pushed
the
joerger/refactor-reauthenticate
branch
4 times, most recently
from
December 6, 2024 00:11
4abf873
to
42ba430
Compare
Joerger
added
no-changelog
Indicates that a PR does not require a changelog entry
backport/branch/v15
backport/branch/v16
backport/branch/v17
and removed
backport/branch/v15
labels
Dec 6, 2024
avatus
reviewed
Dec 6, 2024
ryanclark
approved these changes
Dec 9, 2024
avatus
approved these changes
Dec 9, 2024
public-teleport-github-review-bot
bot
removed the request for review
from flyinghermit
December 9, 2024 21:04
Joerger
force-pushed
the
joerger/refactor-reauthenticate
branch
from
December 9, 2024 22:26
ea8e8eb
to
40336ed
Compare
Joerger
force-pushed
the
joerger/unify-mfa-methods
branch
from
December 9, 2024 22:29
ad04916
to
831528d
Compare
Joerger
force-pushed
the
joerger/refactor-reauthenticate
branch
2 times, most recently
from
December 10, 2024 01:04
af41a4e
to
bdd69ca
Compare
@ryanclark @avatus I added one more commit if you don't mind taking a look e60ec3d |
avatus
approved these changes
Dec 10, 2024
ryanclark
approved these changes
Dec 10, 2024
Joerger
force-pushed
the
joerger/refactor-reauthenticate
branch
from
December 11, 2024 02:41
e60ec3d
to
428e745
Compare
…nt initial mfa option state.
… tokenless mfa endpoints to register/delete mfa devices; add TODOs to use new endpoints in v19+.
Joerger
force-pushed
the
joerger/refactor-reauthenticate
branch
from
December 14, 2024 00:59
428e745
to
8e2fb35
Compare
Joerger
force-pushed
the
joerger/refactor-reauthenticate
branch
from
December 14, 2024 01:18
8e2fb35
to
9e8ad10
Compare
Joerger
force-pushed
the
joerger/refactor-reauthenticate
branch
from
December 14, 2024 01:50
828bded
to
5d0f08d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The overarching change in this PR is the ability of all
Reauthenticate
flows to handle generic MFA challenges (sso, webauthn, otp) rather than handling each type differently or not at all.Note:
useReauthenticate
should now be the goto state handler method for reauthentication flows.Changes:
useReauthenticate
(used in theReauthenticate
components).submitWithMFA
method instead ofsubmitWithWebAuthn
andsubmitWithOTP
. SSO MFA will usesubmitWithMFA('sso')
.OnAuthenticated
propuseReauthenticate
refactors.useReauthenticate
for change password wizard to get the same changes described above.createPrivilegeToken
endpoint to accept generic MFA response instead of TOTP or Webauthn, so it will now support SSO MFA.Note on
/e
: This PR is dependent on the e PR and vice versa. Therefore I'll need to merge this PR with e PR as the head of/e
. Then I'll make a follow up to update the e ref to master once the e PR is merged, shortly after this PR is merged.TODO (follow ups):
Prerequisite for supporting SSO MFA in device management (add/delete), connection tester (discover), change password, and account recovery flows.
Depends on #49678, #49679, https://github.com/gravitational/teleport.e/pull/5656