Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI MFA methods refactor #49679

Merged
merged 6 commits into from
Dec 10, 2024
Merged

WebUI MFA methods refactor #49679

merged 6 commits into from
Dec 10, 2024

Conversation

Joerger
Copy link
Contributor

@Joerger Joerger commented Dec 3, 2024

Replace existing MFA methods which handle only webauthn or otp to handle generic MFA challenges instead. This way we can add SSO MFA support with just one or two small changes.

Depends on #49678

Prerequisite for SSO MFA changes (TODO).

@Joerger Joerger force-pushed the joerger/unify-mfa-types branch 2 times, most recently from 7ae2721 to e0ee68e Compare December 3, 2024 20:33
@Joerger Joerger force-pushed the joerger/unify-mfa-methods branch 2 times, most recently from 518f3ef to 7616ec7 Compare December 3, 2024 21:23
@Joerger Joerger marked this pull request as ready for review December 3, 2024 21:24
@Joerger Joerger requested a review from avatus December 3, 2024 21:24
@github-actions github-actions bot requested review from gzdunek and ryanclark December 3, 2024 21:24
@Joerger Joerger force-pushed the joerger/unify-mfa-types branch from e0ee68e to 9755a70 Compare December 3, 2024 23:31
@Joerger Joerger force-pushed the joerger/unify-mfa-methods branch from 7616ec7 to e2afc8c Compare December 3, 2024 23:37
@Joerger Joerger added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 backport/branch/v16 backport/branch/v17 labels Dec 3, 2024
@Joerger Joerger force-pushed the joerger/unify-mfa-methods branch from e2afc8c to e53c97c Compare December 3, 2024 23:40
@Joerger Joerger mentioned this pull request Dec 4, 2024
@Joerger Joerger force-pushed the joerger/unify-mfa-methods branch 3 times, most recently from 12e84bd to ad04916 Compare December 5, 2024 00:31
@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from ryanclark December 5, 2024 10:01
Base automatically changed from joerger/unify-mfa-types to master December 9, 2024 21:08
@Joerger Joerger force-pushed the joerger/unify-mfa-methods branch from ad04916 to 831528d Compare December 9, 2024 22:30
@Joerger Joerger enabled auto-merge December 9, 2024 22:30
@Joerger Joerger added this pull request to the merge queue Dec 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Dec 9, 2024
@Joerger Joerger added this pull request to the merge queue Dec 10, 2024
Merged via the queue into master with commit 4677873 Dec 10, 2024
40 checks passed
@Joerger Joerger deleted the joerger/unify-mfa-methods branch December 10, 2024 00:51
@public-teleport-github-review-bot

@Joerger See the table below for backport results.

Branch Result
branch/v17 Failed

@public-teleport-github-review-bot

@Joerger See the table below for backport results.

Branch Result
branch/v17 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v17 no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants