-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SSO MFA prompt for WebUI MFA flows #49794
Open
Joerger
wants to merge
6
commits into
joerger/refactor-reauthenticate
Choose a base branch
from
joerger/sso-mfa-method
base: joerger/refactor-reauthenticate
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joerger
force-pushed
the
joerger/refactor-reauthenticate
branch
4 times, most recently
from
December 6, 2024 00:11
4abf873
to
42ba430
Compare
Joerger
force-pushed
the
joerger/sso-mfa-method
branch
2 times, most recently
from
December 9, 2024 22:11
5911b85
to
672dddb
Compare
Joerger
force-pushed
the
joerger/refactor-reauthenticate
branch
from
December 9, 2024 22:26
ea8e8eb
to
40336ed
Compare
Joerger
force-pushed
the
joerger/refactor-reauthenticate
branch
2 times, most recently
from
December 10, 2024 01:04
af41a4e
to
bdd69ca
Compare
Joerger
force-pushed
the
joerger/sso-mfa-method
branch
from
December 10, 2024 01:18
672dddb
to
9ad6250
Compare
Joerger
force-pushed
the
joerger/refactor-reauthenticate
branch
from
December 11, 2024 02:41
e60ec3d
to
428e745
Compare
Joerger
force-pushed
the
joerger/sso-mfa-method
branch
from
December 11, 2024 02:42
9ad6250
to
213322c
Compare
Joerger
force-pushed
the
joerger/refactor-reauthenticate
branch
2 times, most recently
from
December 14, 2024 01:18
8e2fb35
to
9e8ad10
Compare
Joerger
force-pushed
the
joerger/sso-mfa-method
branch
from
December 14, 2024 02:16
213322c
to
fb8c772
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Add full SSO MFA support for the WebUI.
Extends SSO MFA support for:
Reauthenticate
flows (RefactorReauthenticate
components to handle generic MFA challenges. #49680)Depends on #49680
TODO (follow up): Add global MFA prompt for admin action MFA, app session mfa, rather than automatically continuing with webauthn or sso.