-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workload ID: Add Protos for WorkloadIdentity resource, CRUD and events #49650
Merged
strideynet
merged 6 commits into
master
from
strideynet/workload-identity-pbuf-and-events
Dec 6, 2024
Merged
Workload ID: Add Protos for WorkloadIdentity resource, CRUD and events #49650
strideynet
merged 6 commits into
master
from
strideynet/workload-identity-pbuf-and-events
Dec 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strideynet
added
no-changelog
Indicates that a PR does not require a changelog entry
backport/branch/v16
backport/branch/v17
labels
Dec 2, 2024
This pull request is automatically being deployed by Amplify Hosting (learn more). |
strideynet
force-pushed
the
strideynet/workload-identity-pbuf-and-events
branch
3 times, most recently
from
December 5, 2024 10:39
f560fad
to
1c132aa
Compare
strideynet
force-pushed
the
strideynet/workload-identity-pbuf-and-events
branch
from
December 5, 2024 10:43
1c132aa
to
36d4bb2
Compare
tigrato
reviewed
Dec 5, 2024
tigrato
approved these changes
Dec 5, 2024
timothyb89
approved these changes
Dec 5, 2024
public-teleport-github-review-bot
bot
removed the request for review
from atburke
December 5, 2024 18:15
capnspacehook
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the TrimToMaxSize
impl!
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
Dec 9, 2024
#49650) * Add protos for resource and resource svc * Add field for encoding the created/updated workloadidentity in audit events * Remove redundant package qualifier * Add UpsertWorkloadIdentity * Appease linter * Add TrimToMaxSize implementation
strideynet
added a commit
that referenced
this pull request
Dec 9, 2024
#49650) * Add protos for resource and resource svc * Add field for encoding the created/updated workloadidentity in audit events * Remove redundant package qualifier * Add UpsertWorkloadIdentity * Appease linter * Add TrimToMaxSize implementation
This was referenced Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
audit-log
Issues related to Teleports Audit Log
backport/branch/v16
backport/branch/v17
no-changelog
Indicates that a PR does not require a changelog entry
size/md
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds protos for the new WorkloadIdentity resource, along with the Audit Event protos and similar.
I've gone with the most basic version of the protos presented in the RFD for now. I figure it makes sense to move forward with this boilerplatery work whilst the finer points of the RFD are discussed.
As per RFD: #49133
Part of #49572