Workload ID: Add WorkloadIdentity local service and cache config #49942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
strideynet
changed the title
strideynet
added
no-changelog
EdwardDowling
approved these changes
Dec 9, 2024
Co-authored-by: Edward Dowling <[email protected]>
Co-authored-by: Edward Dowling <[email protected]>
espadolini
approved these changes
Dec 9, 2024
Comment on lines
+81
to
+82
| case s == nil: | ||
| return trace.BadParameter("object cannot be nil") |
There was a problem hiding this comment.
nil is a perfectly valid empty read-only protobuf message object 😭
public-teleport-github-review-bot
bot
removed the request for review
from capnspacehook
Co-authored-by: Edoardo Spadolini <[email protected]>
strideynet
deleted the
strideynet/add-workload-identity-service-and-cache
branch
|
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
Dec 10, 2024
) * Add WorkloadIdentity store and cache * Update lib/services/local/workload_identity.go Co-authored-by: Edward Dowling <[email protected]> * Update lib/services/local/workload_identity.go Co-authored-by: Edward Dowling <[email protected]> * Update lib/cache/resource_workload_identity.go Co-authored-by: Edoardo Spadolini <[email protected]> --------- Co-authored-by: Edward Dowling <[email protected]> Co-authored-by: Edoardo Spadolini <[email protected]>
strideynet
added a commit
that referenced
this pull request
Dec 10, 2024
) * Add WorkloadIdentity store and cache * Update lib/services/local/workload_identity.go Co-authored-by: Edward Dowling <[email protected]> * Update lib/services/local/workload_identity.go Co-authored-by: Edward Dowling <[email protected]> * Update lib/cache/resource_workload_identity.go Co-authored-by: Edoardo Spadolini <[email protected]> --------- Co-authored-by: Edward Dowling <[email protected]> Co-authored-by: Edoardo Spadolini <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
#49942) (#49990) * Workload ID: Add WorkloadIdentity local service and cache config (#49942) * Add WorkloadIdentity store and cache * Update lib/services/local/workload_identity.go Co-authored-by: Edward Dowling <[email protected]> * Update lib/services/local/workload_identity.go Co-authored-by: Edward Dowling <[email protected]> * Update lib/cache/resource_workload_identity.go Co-authored-by: Edoardo Spadolini <[email protected]> --------- Co-authored-by: Edward Dowling <[email protected]> Co-authored-by: Edoardo Spadolini <[email protected]> * Fix for v16 * Fix dodgy backport with incorrect Kind --------- Co-authored-by: Edward Dowling <[email protected]> Co-authored-by: Edoardo Spadolini <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 10, 2024
) (#49988) * Add WorkloadIdentity store and cache * Update lib/services/local/workload_identity.go * Update lib/services/local/workload_identity.go * Update lib/cache/resource_workload_identity.go --------- Co-authored-by: Edward Dowling <[email protected]> Co-authored-by: Edoardo Spadolini <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #49650
Adds the
lib/services/localandlib/cacheimplementation for the WorkloadIdentity Resource.This content was originally in PR #49639 which had two approvals - but was split out to avoid an XLarge PR.