-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFD191: Rework Workload Identity Configuration and RBAC UX #49133
Conversation
Ready for first pass opinions on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few thoughts after a first readthrough
Co-authored-by: Tim Buckley <[email protected]>
…nal/teleport into rfd/191-workload-id-config-ux
I think largely, we need to ask design partners about the types of rules they would write, and understand how they'd prefer to express these. Generally, it seems like option 1 and option 3 are the most sensible to move forward with. Option 2 seems to push the complexity of what's reasonable in YAML and causes problems for generation of IaC due to recursion. |
@thedevelopnik / @timothyb89 please take another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good! I think you found a good compromise supporting both YAML conditions and expressions for rules.
TTL will be capped at this value. This provides the ability to enforce a | ||
maximum permissible TTL regardless of the configuration of the `tbot` agent. | ||
|
||
If this field is not set, a default maximum value of 24 hours will be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we / the SPIFFE spec define an upper limit to the TTL, or is it arbitrary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SPIFFE doesn't specify anything. Across the rest of Teleport we do have some limits, but, I'm leaning towards that we may want to relax these for Workload Identity in order to support some more niche use-cases.
Related to #44006