Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workload_identity_labels to RoleCondition #50071

Merged
merged 13 commits into from
Dec 12, 2024

Conversation

strideynet
Copy link
Contributor

@strideynet strideynet commented Dec 11, 2024

Part of #49574
As per RFD 191: #49133

Adds the workload_identity_labels label matcher to role conditions. This will be used to grant/restrict access to issuing workload credentials using the WorkloadIdentity resource.

This is a pre-req of a later PR that will introduce the IssueWorkloadIdentity RPC.

@strideynet strideynet added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v16 backport/branch/v17 labels Dec 11, 2024
Copy link

🤖 Vercel preview here: https://docs-1v99hxzko-goteleport.vercel.app/docs

Copy link

🤖 Vercel preview here: https://docs-8r1mm7rzb-goteleport.vercel.app/docs

@strideynet strideynet changed the title Strideynet/add workload identity role labels Add workload_identity_labels to RoleCondition Dec 11, 2024
@strideynet strideynet marked this pull request as ready for review December 11, 2024 17:47
Copy link

🤖 Vercel preview here: https://docs-m02gdzi8f-goteleport.vercel.app/docs

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from xinding33 December 11, 2024 18:48
Copy link
Contributor

@tigrato tigrato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requesting a change here

api/proto/teleport/legacy/types/types.proto Show resolved Hide resolved
Copy link

🤖 Vercel preview here: https://docs-gdmrc0dsd-goteleport.vercel.app/docs

Copy link

🤖 Vercel preview here: https://docs-9h59j5cen-goteleport.vercel.app/docs

Copy link

🤖 Vercel preview here: https://docs-ompn2frlw-goteleport.vercel.app/docs

Copy link

🤖 Vercel preview here: https://docs-98rihoijk-goteleport.vercel.app/docs

@strideynet strideynet enabled auto-merge December 12, 2024 10:56
….com:gravitational/teleport into strideynet/add-workload-identity-role-labels
Copy link

🤖 Vercel preview here: https://docs-a2crz4827-goteleport.vercel.app/docs

@strideynet strideynet added this pull request to the merge queue Dec 12, 2024
Merged via the queue into master with commit 49c3083 Dec 12, 2024
44 checks passed
@strideynet strideynet deleted the strideynet/add-workload-identity-role-labels branch December 12, 2024 12:05
@public-teleport-github-review-bot

@strideynet See the table below for backport results.

Branch Result
branch/v16 Failed
branch/v17 Failed

strideynet added a commit that referenced this pull request Dec 12, 2024
* Add WorkloadIdentityLabels field to role

* Wire up access checker

* Add validation for new field

* Update CRDs

* Add to terraform provider

* Mispel some words to keep the republic happy

* Add WorkloadIdentityLabelsExpression

* Update Terraform provider

* Add to operator CRD

* PLS RUN CLA CHECK
strideynet added a commit that referenced this pull request Dec 12, 2024
* Add WorkloadIdentityLabels field to role

* Wire up access checker

* Add validation for new field

* Update CRDs

* Add to terraform provider

* Mispel some words to keep the republic happy

* Add WorkloadIdentityLabelsExpression

* Update Terraform provider

* Add to operator CRD

* PLS RUN CLA CHECK
github-merge-queue bot pushed a commit that referenced this pull request Dec 12, 2024
* Add WorkloadIdentityLabels field to role

* Wire up access checker

* Add validation for new field

* Update CRDs

* Add to terraform provider

* Mispel some words to keep the republic happy

* Add WorkloadIdentityLabelsExpression

* Update Terraform provider

* Add to operator CRD

* PLS RUN CLA CHECK
github-merge-queue bot pushed a commit that referenced this pull request Dec 12, 2024
* Add `workload_identity_labels` to RoleCondition (#50071)

* Add WorkloadIdentityLabels field to role

* Wire up access checker

* Add validation for new field

* Update CRDs

* Add to terraform provider

* Mispel some words to keep the republic happy

* Add WorkloadIdentityLabelsExpression

* Update Terraform provider

* Add to operator CRD

* PLS RUN CLA CHECK

* Backport `resource153ToResourceWithLabelsAdapter`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants