Updates RUST_VERSION and bumps IronRDP rev to latest, adding RUST_MIN_STACK to fix ARM builds
#39895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure if the changelog tooling allows multiple changelog entries, but I would want to see two for this PR:
|
…ow-dependencies-licenses. This is required because their crates do not currently have valid SPDX licenses, see https://github.com/gravitational/teleport/actions/runs/8453649354/job/23156810330?pr=39895
ibeckermayer
requested review from
klizhentas,
russjones,
r0mant,
fheinecke,
camscale and
tcsc
as code owners
zmb3
approved these changes
Mar 27, 2024
ibeckermayer
commented
Mar 27, 2024
Comment on lines
+16
to
+24
| allow-dependencies-licenses: >- | ||
| pkg:cargo/curve25519-dalek-derive, | ||
| pkg:cargo/ring, | ||
| pkg:cargo/sspi, | ||
| pkg:cargo/tokio-boring, | ||
| pkg:cargo/asn1-rs, | ||
| pkg:cargo/asn1-rs-derive, | ||
| pkg:cargo/asn1-rs-impl, | ||
| pkg:cargo/der-parser |
There was a problem hiding this comment.
Issue tracking these is here: #35993
jakule
approved these changes
Mar 27, 2024
public-teleport-github-review-bot
bot
removed request for
probakowski,
ryanclark and
rudream
probakowski
approved these changes
Mar 27, 2024
|
@ibeckermayer See the table below for backport results.
|
ibeckermayer
pushed a commit
that referenced
this pull request
Mar 28, 2024
…MIN_STACK` to fix ARM builds (#39895) * Updates RUST_VERSION and IronRDP rev to latest, adds RUST_MIN_STACK to fix ARM builds * Adds asn1-rs, asn1-rs-derive, asn1-rs-impl, and der-parser to the allow-dependencies-licenses. This is required because their crates do not currently have valid SPDX licenses, see https://github.com/gravitational/teleport/actions/runs/8453649354/job/23156810330?pr=39895
This was referenced Mar 28, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Mar 29, 2024
* Updates `RUST_VERSION` and bumps IronRDP rev to latest, adding `RUST_MIN_STACK` to fix ARM builds (#39895) * Updates RUST_VERSION and IronRDP rev to latest, adds RUST_MIN_STACK to fix ARM builds * Adds asn1-rs, asn1-rs-derive, asn1-rs-impl, and der-parser to the allow-dependencies-licenses. This is required because their crates do not currently have valid SPDX licenses, see https://github.com/gravitational/teleport/actions/runs/8453649354/job/23156810330?pr=39895 * Fixes linting errors that showed up due to recent rust version update from 1.71.1 to 1.77.0 (#39981)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been stuck on an older
RUST_VERSIONfor a while, and thus an older IronRDP hash (because later hashes require more-recently-stabilized rust features), because updating rust was causing aSIGSEGVerror when building the wasm on ARM/linux.Following a recent update to the rust compiler output, this PR solves all of that:
Fixes #39772
changelog: Update Rust to
1.77.0, enable RDP font smoothing