-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v13] Update rust to latest stable (1.77.0) #39990
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
camscale,
fheinecke,
jakule,
klizhentas,
probakowski,
r0mant,
russjones,
tcsc and
zmb3
March 28, 2024 22:21
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
zmb3
changed the title
Updates rust to latest stable (
[v13] Update rust to latest stable (1.77.0)
Mar 28, 2024
1.77.0
)
probakowski
approved these changes
Mar 29, 2024
@ibeckermayer Do you mind fixing the lint errors? I usually wait to review until CI passes, so this has been on my list for a couple of weeks now... |
This is a temporary hack to get CI to pass. It is necessary for the RUST_VERSION which we are updating to (1.77.0), however CI is still using an image with the previous version 1.71.1. Meanwhile `arc_with_non_send_sync` was added in 1.72.0 (https://rust-lang.github.io/rust-clippy/master/index.html#/arc_with_non_send_sync). The PR with this commit will therefore require a follow up PR to uncomment the line once the CI image is updated.
1 task
camscale
approved these changes
Apr 15, 2024
public-teleport-github-review-bot
bot
removed request for
klizhentas,
r0mant,
tcsc,
russjones,
zmb3 and
jakule
April 15, 2024 21:28
public-teleport-github-review-bot
bot
removed the request for review
from fheinecke
April 15, 2024 21:28
camscale
added
the
no-changelog
Indicates that a PR does not require a changelog entry
label
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
desktop-access
no-changelog
Indicates that a PR does not require a changelog entry
rdp
size/sm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roughly a backport for #39895 and #39981, however the rust codebase have diverged enough between this branch and
master
that I am considering this its own thing.Confirm that build succeeds:
changelog: updates rust to
1.77.0