Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v13] Update rust to latest stable (1.77.0) #39990

Merged
merged 4 commits into from
Apr 15, 2024

Conversation

ibeckermayer
Copy link
Contributor

@ibeckermayer ibeckermayer commented Mar 28, 2024

Roughly a backport for #39895 and #39981, however the rust codebase have diverged enough between this branch and master that I am considering this its own thing.

Confirm that build succeeds:

changelog: updates rust to 1.77.0

Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@zmb3 zmb3 changed the title Updates rust to latest stable (1.77.0) [v13] Update rust to latest stable (1.77.0) Mar 28, 2024
@camscale
Copy link
Contributor

@ibeckermayer Do you mind fixing the lint errors? I usually wait to review until CI passes, so this has been on my list for a couple of weeks now...

This is a temporary hack to get CI to pass. It is necessary for the
RUST_VERSION which we are updating to (1.77.0), however CI is still
using an image with the previous version 1.71.1. Meanwhile `arc_with_non_send_sync`
was added in 1.72.0 (https://rust-lang.github.io/rust-clippy/master/index.html#/arc_with_non_send_sync).

The PR with this commit will therefore require a follow up PR to uncomment
the line once the CI image is updated.
@ibeckermayer
Copy link
Contributor Author

@camscale I had to add a sort of hack here to get CI to pass, see the commit message for 442c98b

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from fheinecke April 15, 2024 21:28
@ibeckermayer ibeckermayer added this pull request to the merge queue Apr 15, 2024
Merged via the queue into branch/v13 with commit 5f2d3ec Apr 15, 2024
22 checks passed
@ibeckermayer ibeckermayer deleted the isaiah/update-rust-branch/v13 branch April 15, 2024 22:16
@camscale camscale added the no-changelog Indicates that a PR does not require a changelog entry label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport desktop-access no-changelog Indicates that a PR does not require a changelog entry rdp size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants