Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capture stderr from "tsh db connect" and reformat redis error #13843

Merged
merged 9 commits into from
Jul 5, 2022
Merged

Capture stderr from "tsh db connect" and reformat redis error #13843

merged 9 commits into from
Jul 5, 2022

Conversation

greedy52
Copy link
Contributor

@greedy52 greedy52 commented Jun 24, 2022 •
edited
Loading

Fixes #13731

$ tsh db connect --insecure steve-redis
Unrecognized option or bad number of args for: '--insecure'
ERROR: '/opt/homebrew/bin/redis-cli' has exited with the above error. Please make sure 'redis-cli' with version 6.2 or newer is installed.

@greedy52 greedy52 changed the title Capture stderr and reformat redis error Capture stderr from "tsh db connect" and reformat redis error Jun 24, 2022
@greedy52 greedy52 self-assigned this Jun 24, 2022
@greedy52 greedy52 added tsh tsh - Teleport's command line tool for logging into nodes running Teleport. db/redis labels Jun 24, 2022
@greedy52 greedy52 requested a review from gabrielcorado June 27, 2022 13:43
@greedy52 greedy52 marked this pull request as ready for review June 27, 2022 13:43
@greedy52 greedy52 requested a review from smallinsky June 27, 2022 13:44
gabrielcorado
gabrielcorado approved these changes Jun 27, 2022
View reviewed changes
tool/tsh/db.go Outdated Show resolved Hide resolved
tool/tsh/db.go Outdated Show resolved Hide resolved
smallinsky
smallinsky approved these changes Jun 28, 2022
View reviewed changes
tool/tsh/db.go Outdated Show resolved Hide resolved
lib/utils/writer.go Show resolved Hide resolved
@Joerger Joerger mentioned this pull request Jul 1, 2022
Closed
@greedy52 greedy52 enabled auto-merge (squash) July 5, 2022 19:38
@greedy52 greedy52 merged commit cf88c0a into master Jul 5, 2022
@greedy52 greedy52 deleted the STeve/13731_impore_tsh_redis_error_message branch July 10, 2022 19:55
@GavinFrazar
Copy link
Contributor

Could we backport this?

greedy52 added a commit that referenced this pull request Sep 14, 2022
@greedy52
Capture stderr from "tsh db connect" and reformat redis error (#13843)
6e84f00
@greedy52 greedy52 mentioned this pull request Sep 14, 2022
Merged
greedy52 added a commit that referenced this pull request Sep 14, 2022
@greedy52
Capture stderr from "tsh db connect" and reformat redis error (#13843)
3caee92
@greedy52 greedy52 mentioned this pull request Sep 14, 2022
Merged
greedy52 added a commit that referenced this pull request Sep 14, 2022
@greedy52
Capture stderr from "tsh db connect" and reformat redis error (#13843) (
3be967b 
#16416)
greedy52 added a commit that referenced this pull request Sep 16, 2022
@greedy52
Capture stderr from "tsh db connect" and reformat redis error (#13843) (
b3c1f64 
#16419)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrielcorado gabrielcorado gabrielcorado approved these changes

@ptgott ptgott ptgott approved these changes

@smallinsky smallinsky smallinsky approved these changes

@avatus avatus Awaiting requested review from avatus

@r0mant r0mant Awaiting requested review from r0mant

@xinding33 xinding33 Awaiting requested review from xinding33

@zmb3 zmb3 Awaiting requested review from zmb3

Assignees

@greedy52 greedy52

Labels
db/redis documentation tsh tsh - Teleport's command line tool for logging into nodes running Teleport.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalid --insecure flag when connecting to Redis database
5 participants
@greedy52 @GavinFrazar @gabrielcorado @smallinsky @ptgott