[v9] Capture stderr from "tsh db connect" and reformat redis error (#13843) #16419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
documentation
tsh
github-actions
bot
requested review from
avatus,
gabrielcorado,
ptgott,
r0mant,
smallinsky,
xinding33 and
zmb3
smallinsky
approved these changes
Sep 15, 2022
GavinFrazar
approved these changes
Sep 15, 2022
|
Thanks @GavinFrazar! BTW, neither the |
ptgott
approved these changes
Sep 16, 2022
github-actions
bot
removed request for
r0mant,
gabrielcorado,
avatus,
zmb3 and
xinding33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #13843
A minor change to beautify "redis-cli" error so didn't backport it. Now required by #16228.
Cherrypick has one minor conflict in the import block (v9 is still using
"io/ioutil").