Invalid --insecure flag when connecting to Redis database

[gabrielcorado]

When connecting to a Redis instance with the insecure flag it returns an error related to the flag not being recognized. Looking at the logs, it seems that the tsh flag is being passed to the redis-cli command, causing the error.

$ tsh db connect --insecure redis
Unrecognized option or bad number of args for: '--insecure'
ERROR: exit status 1

$ tsh db connect -d --insecure redis
...
DEBU [TSH]       Starting local proxy tsh/db.go:517
DEBU [TSH]       /usr/bin/redis-cli -h localhost -p 44949 --tls --key /home/ubuntu/.tsh/keys/teleport/alice --cert /home/ubuntu/.tsh/keys/teleport/alice-db/teleport/redis-x509.pem --insecure --cacert /home/ubuntu/.tsh/keys/teleport/cas/teleport.pem tsh/db.go:681
Unrecognized option or bad number of args for: '--insecure'

ERROR REPORT:
Original Error: *exec.ExitError exit status 1
Stack Trace:
        /home/ubuntu/teleport/tool/tsh/db.go:687 main.onDatabaseConnect
        /home/ubuntu/teleport/tool/tsh/tsh.go:920 main.Run
        /home/ubuntu/teleport/tool/tsh/tsh.go:396 main.main
        /usr/lib/go-1.18/src/runtime/proc.go:250 runtime.main
        /usr/lib/go-1.18/src/runtime/asm_amd64.s:1571 runtime.goexit
User Message: exit status 1

Bug details:

• Teleport version: branch/v10
• Redis CLI version: 6.0.16
• Recreation steps:
  • tsh db login --insecure redis: Login into a Redis database with insecure set;
  • tsh db connect --insecure redis: Connect into the Redis database with insecure set;

[greedy52]

--insecure is not supported on redis-cli 6.0 or older. Will add a proper message seeing these errors