Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iq tool gui fixes #1011

Closed
wants to merge 3 commits into from
Closed

Iq tool gui fixes #1011

wants to merge 3 commits into from

Conversation

vladisslav2011
Copy link
Contributor

@vladisslav2011 vladisslav2011 commented Dec 3, 2021 •
edited
Loading

Fix IQ Tool file list jumpy scrollbar.
Always choose correct sample rate when starting IQ playback.
Disable GUI controls, that have no use or may break things during playback/recording of an IQ file.

Previous in series #1010
Next in series #1013
Closes #1037

@vladisslav2011 vladisslav2011 mentioned this pull request Dec 15, 2021
Merged
@vladisslav2011 vladisslav2011 marked this pull request as draft December 18, 2021 20:07
@vladisslav2011
Copy link
Contributor Author

Rebased on top of current iq_tool_center_freq_lock.
May need more work in case iq_tool_add_sr_freq_inputs gets merged.

@vladisslav2011 vladisslav2011 marked this pull request as ready for review December 18, 2021 21:29
@vladisslav2011 vladisslav2011 force-pushed the iq_tool_gui_fixes branch 2 times, most recently from 1965c5d to 429683f Compare December 27, 2021 03:08
@vladisslav2011 vladisslav2011 mentioned this pull request Dec 31, 2021
Closed
@vladisslav2011 vladisslav2011 force-pushed the iq_tool_gui_fixes branch 4 times, most recently from 1b8c813 to d2d397b Compare December 31, 2021 18:05
@vladisslav2011 vladisslav2011 force-pushed the iq_tool_gui_fixes branch 2 times, most recently from 5dc6c85 to d0d8611 Compare August 21, 2022 00:15
@vladisslav2011 vladisslav2011 mentioned this pull request Nov 6, 2022
Draft
@pinkavaj
Copy link
Contributor

pinkavaj commented Nov 6, 2022

Looks like the IQ tool: prevent accidental change of hw freq is not related to this change, would it be possible to drop it? Also it looks like this MR does more thinks at once. For CR might be helpful to split it into smaller pieces, if possible.

This was referenced Nov 6, 2022
Open
Open
@vladisslav2011
Copy link
Contributor Author

I'll try to rebase c452ac8 on top of current master and, maybe, split it into multiple small commits.

@vladisslav2011
Copy link
Contributor Author

Rebased.
Works, but recording without buffering is laggy.

@vladisslav2011
Copy link
Contributor Author

I've tried to review this PR myself and found 2 unused variables: MainWindow::backupFreq and MainWindow::backupOffset.
I'll remove that and update the RP.
I'll try to split this into 3 commits (maybe 3 PRs): jumping slider fix, controls state management and correct sample rate selection.

@vladisslav2011
IQ Tool: Fix jumpy scrollbar of IQ player
e2b8fce 
When file list grows long and the user tries to scroll the list to a new
postion, the list continues to return it's scroll to the last selected item.
That's really annoying.
Return the list to last seen position after refreshing it's contents.
@vladisslav2011
IQ tool: Always choose correct sampling rate
51f1835 
Reselect file before starting playback. Fixes incorrect sample rate
when playback is started, stopped, devices switched, dsp started,
stopped and then started playback of the same IQ file.
@vladisslav2011
IQ tool: disable unused controls when recording/playback is in progress.
1306107 
Changing IO devices and loading/saving settings does not look like good thing
to do while recording/playing an IQ file.
Disable seek slider during recording as it has no function in this
state.
Disable file list and directory selector during recording/playback.
@vladisslav2011
Copy link
Contributor Author

Updated.

@pinkavaj
Copy link
Contributor

I'm looking forward to the jumpy file list fix. Would you please consider to split it into separate MR? My hope is such a small change can make it quick to the master.

@vladisslav2011
Copy link
Contributor Author

OK. I'll split this into 3 PRs. Wait some minutes, please.

@vladisslav2011 vladisslav2011 marked this pull request as draft November 10, 2022 21:27
@vladisslav2011
Copy link
Contributor Author

This PR was split into #1169 #1170 #1170
Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinkavaj pinkavaj pinkavaj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I/Q tool file selector randomly jumps to current selection
2 participants
@vladisslav2011 @pinkavaj