Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IQ tool: Always choose correct sampling rate #1170

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vladisslav2011
Copy link
Contributor

Reselect file before starting playback. Fixes incorrect sample rate when playback is started, stopped, devices switched, dsp started, stopped and then started playback of the same IQ file.
Demonstration: https://www.youtube.com/watch?v=IFOt8htn7MM

@pinkavaj
Copy link
Contributor

Would not this be fixed also by #1026? It looks like in #1026 the recording and playback samplerates are independent and did not get confused. Consider using the #1026 without the UI changes as a fix for this, at the same time it should pave the way for #1026 is-self.

@argilo argilo added the bug label Mar 25, 2023
Reselect file before starting playback. Fixes incorrect sample rate
when playback is started, stopped, devices switched, dsp started,
stopped and then started playback of the same IQ file.
@vladisslav2011 vladisslav2011 force-pushed the iq_tool_wrong_sample_rate_fix branch from 16380a2 to 478a2bd Compare July 28, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants