IQ Tool: Fix jumpy scrollbar of IQ player #1169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When file list grows long and the user tries to scroll the list to a new postion, the list continues to return it's scroll to the last selected item. That's really annoying. Return the list to last seen position after refreshing it's contents.
|
This is definitely an improvement. Thanks! |
|
@argilo Should we add the news line too or is it somethink you would preffer to do your-selves? |
Closed
|
I usually add the news items myself just before merging. Including that earlier would sometimes lead to merge conflicts, so I think it's best not to include it in pull requests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When file list grows long and the user tries to scroll the list to a new position, the list continues to return it's scroll to the last selected item. That's really annoying.
Return the list to last seen position after refreshing it's contents.
Demonstration: https://www.youtube.com/watch?v=DW3LpVRxGoA
Closes #1037