fix: Update CI to use kokoro and build for OSX, Windows, Linux #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsg
force-pushed
the
migrate_release_kokoro
branch
from
7a2b4a5 to
7ce2730
Compare
andrewsg
force-pushed
the
migrate_release_kokoro
branch
from
2bfceac to
520437f
Compare
andrewsg
force-pushed
the
migrate_release_kokoro
branch
from
dfd4952 to
0d9d7e5
Compare
andrewsg
force-pushed
the
migrate_release_kokoro
branch
from
c0f9308 to
3279df1
Compare
andrewsg
force-pushed
the
migrate_release_kokoro
branch
from
66bdb10 to
6d443cd
Compare
| @rem Unfortunately pyenv for Windows has an out-of-date versions list. Choco's | ||
| @rem installer seems to have some problems with installing multiple versions at | ||
| @rem once, so as a workaround, we will install and then uninstall every version. | ||
| FOR %%P IN (3.8, 3.9, 3.10, 3.11, 3.12) DO ( |
There was a problem hiding this comment.
chocolatey seems to translate, for example, 3.8 to 3.8.0 (see chocolatey/choco#800). So you might wanna use more specific versions here:
Suggested change
| FOR %%P IN (3.8, 3.9, 3.10, 3.11, 3.12) DO ( | |
| FOR %%P IN (3.8.19, 3.9.19, 3.10.14, 3.11.9, 3.12.4) DO ( |
There was a problem hiding this comment.
Yes, unfortunately, making that change will break the rest of the code around python versions, so I will need to do a translation. It's on the docket for later.
parthea
reviewed
Jul 9, 2024
Comment on lines
+81
to
+88
| # Upload wheels to GCS for debugging. Uncomment only when needed. | ||
|
|
||
| export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/service-account.json | ||
| gcloud auth activate-service-account --key-file=${GOOGLE_APPLICATION_CREDENTIALS} | ||
| ls ${REPO_ROOT}/wheels/ | ||
| gsutil cp ${REPO_ROOT}/wheels/* gs://python_crc32c/ | ||
| echo "Osx wheels uploaded successfully" | ||
|
|
There was a problem hiding this comment.
Suggested change
| # Upload wheels to GCS for debugging. Uncomment only when needed. | |
| export GOOGLE_APPLICATION_CREDENTIALS=${KOKORO_GFILE_DIR}/service-account.json | |
| gcloud auth activate-service-account --key-file=${GOOGLE_APPLICATION_CREDENTIALS} | |
| ls ${REPO_ROOT}/wheels/ | |
| gsutil cp ${REPO_ROOT}/wheels/* gs://python_crc32c/ | |
| echo "Osx wheels uploaded successfully" |
Remove test code
|
Superseded by #234 |
parthea
added a commit
that referenced
this pull request
Aug 27, 2024
* build: fix windows presubmit * Apply fix from #214
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
devpackage release with this branchNote: