Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix windows presubmit #237

Merged
merged 3 commits into from
Aug 27, 2024
Merged

build: fix windows presubmit #237

merged 3 commits into from
Aug 27, 2024

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Aug 27, 2024

Fixes #223 🦕

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 27, 2024
@parthea parthea force-pushed the fix-windows-presubmit branch from 3c9c86c to 14eda98 Compare August 27, 2024 13:39
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 27, 2024
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 27, 2024
@parthea parthea marked this pull request as ready for review August 27, 2024 17:23
@parthea parthea requested a review from a team as a code owner August 27, 2024 17:23
@parthea parthea assigned andrewsg and unassigned dizcology Aug 27, 2024
@parthea parthea requested a review from andrewsg August 27, 2024 17:23
@parthea parthea enabled auto-merge (squash) August 27, 2024 17:34
@parthea parthea merged commit c44b65f into main Aug 27, 2024
12 checks passed
@parthea parthea deleted the fix-windows-presubmit branch August 27, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Kokoro build presubmit can be green even if tests fail.
3 participants