Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update CI to use GitHub actions and build for osx, windows, linux #51

Merged
merged 10 commits into from
Jan 13, 2021
Merged

fix: Update CI to use GitHub actions and build for osx, windows, linux #51

merged 10 commits into from
Jan 13, 2021

Conversation

crwilcox
Copy link
Collaborator

@crwilcox crwilcox commented Jan 12, 2021 •
edited
Loading

This PR

  1. fixes an issue in DLL discovery for 3.8, 3.9 on windows
  2. configures github actions for releasing new wheels
  3. removes kokoro based presubmit, continuous, release runs that are now covered here.

@crwilcox crwilcox requested a review from a team as a code owner January 12, 2021 22:35
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 12, 2021
andrewsg
andrewsg requested changes Jan 12, 2021
View reviewed changes
src/google_crc32c/__config__.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
@crwilcox
Copy link
Collaborator Author

Will add separate commits to remove some of the old CI that this replaces

@crwilcox crwilcox changed the title fix: Update CI to use GitHub actions and build for osx, windows, linux fix: Update CI to use GitHub actions and build for osx, windows, linux Jan 12, 2021
@crwilcox
Copy link
Collaborator Author

crwilcox commented Jan 12, 2021 •
edited
Loading

This action won't run until merge, I have a followup PR to update the readme a bit for this project.

image

andrewsg
andrewsg approved these changes Jan 12, 2021
View reviewed changes
Copy link
Contributor

@andrewsg andrewsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with the caveat that I don't understand the yaml file requirements so if it's hand-crafted I can't review its correctness. Thanks for this work!

@crwilcox
Copy link
Collaborator Author

@andrewsg I did run these with different triggers on my fork so I expect they work as expected 👍

@crwilcox crwilcox merged commit 66f49b8 into googleapis:master Jan 13, 2021
@crwilcox crwilcox deleted the add-gh-actions branch January 13, 2021 07:10
@parthea parthea mentioned this pull request Mar 11, 2024
Closed
vishwarajanand added a commit that referenced this pull request May 15, 2024
@vishwarajanand
Revert "fix: Update CI to use GitHub actions and build for osx, windo…
9873c73 
…ws, linux (#51)"

This reverts commit 66f49b8.
@parthea parthea mentioned this pull request Aug 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crwilcox @andrewsg