feat: expose retryable error codes to users #879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
product-auto-label
bot
added
size: l
daniel-sanche
changed the title
| default_operation_timeout=default_operation_timeout, | ||
| default_attempt_timeout=default_attempt_timeout, | ||
| ) | ||
| return TableAsync(self, instance_id, table_id, *args, **kwargs) |
There was a problem hiding this comment.
can you add a comment to TableAsync ctor that reminds people to update this doc when adding args?
| default_mutate_rows_retryable_errors: Sequence[ | ||
| grpc.StatusCode | int | type[Exception] | ||
| ] = (DeadlineExceeded, ServiceUnavailable), | ||
| default_retryable_errors: Sequence[grpc.StatusCode | int | type[Exception]] = ( |
There was a problem hiding this comment.
I would suggest to pick one way to express error types and stick with it. I dont think there much to gain from this flexibility
There was a problem hiding this comment.
Are you ok with sticking with type[Exception]? That's what api-core uses in retries, so it would be simplest. But I thought you mentioned that it should accept StatusCodes at one point
| @@ -566,13 +609,16 @@ async def read_rows( | |||
| *, | |||
| operation_timeout: float | TABLE_DEFAULT = TABLE_DEFAULT.READ_ROWS, | |||
| attempt_timeout: float | None | TABLE_DEFAULT = TABLE_DEFAULT.READ_ROWS, | |||
| retryable_errors: Sequence[grpc.StatusCode | int | type[Exception]] | |||
| | TABLE_DEFAULT = TABLE_DEFAULT.READ_ROWS, | |||
There was a problem hiding this comment.
Should TABLE_DEFAULT enum be prefixed with an underscore? My understanding is that its used as a marker value to signal that the user passed something in. I dont think it makes sense for endusers to be able to set it
There was a problem hiding this comment.
I can see arguments either way. TABLE_DEFAULT already exists in the codebase for handling timeouts though, so if we want to change it, maybe it should be a separate PR?
igorbernstein2
approved these changes
Nov 22, 2023
daniel-sanche
merged commit 285cdd3
into
googleapis:experimental_v3
6 of 10 checks passed
daniel-sanche
added a commit
that referenced
this pull request
Feb 5, 2024
* feat: add new v3.0.0 API skeleton (#745) * feat: improve rows filters (#751) * feat: read rows query model class (#752) * feat: implement row and cell model classes (#753) * feat: add pooled grpc transport (#748) * feat: implement read_rows (#762) * feat: implement mutate rows (#769) * feat: literal value filter (#767) * feat: row_exists and read_row (#778) * feat: read_modify_write and check_and_mutate_row (#780) * feat: sharded read rows (#766) * feat: ping and warm with metadata (#810) * feat: mutate rows batching (#770) * chore: restructure module paths (#816) * feat: improve timeout structure (#819) * fix: api errors apply to all bulk mutations * chore: reduce public api surface (#820) * feat: improve error group tracebacks on < py11 (#825) * feat: optimize read_rows (#852) * chore: add user agent suffix (#842) * feat: optimize retries (#854) * feat: add test proxy (#836) * chore(tests): add conformance tests to CI for v3 (#870) * chore(tests): turn off fast fail for conformance tets (#882) * feat: add TABLE_DEFAULTS enum for table method arguments (#880) * fix: pass None for retry in gapic calls (#881) * feat: replace internal dictionaries with protos in gapic calls (#875) * chore: optimize gapic calls (#863) * feat: expose retryable error codes to users (#879) * chore: update api_core submodule (#897) * chore: merge main into experimental_v3 (#900) * chore: pin conformance tests to v0.0.2 (#903) * fix: bulk mutation eventual success (#909) --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to set retryable error codes at the rpc level, or at the table level
Users can donfigure retryable errors using grpc.StatusCode objects, int codes corresponding to a grpc status, or an Exception type
Fixes: #787
Blocked on #880; if we decide to change how table defaults are configured, that will have implications for this change as well