feat: read rows query model class #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
Mariatta
reviewed
Mar 22, 2023
Mariatta
reviewed
Mar 22, 2023
tests/unit/test_read_rows_query.py
Outdated
| self.assertEqual(query.row_ranges[4][0], None) | ||
| self.assertEqual(query.row_ranges[4][1], None) | ||
| # test with inclusive flags only | ||
| with self.assertRaises(ValueError): |
There was a problem hiding this comment.
add_range seems to be raising ValueError with varying messages. Perhaps we can also check which error message is being raised in each of the errors below.
There was a problem hiding this comment.
good point, I added that to all the raises statements
daniel-sanche
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
mutianf
reviewed
Mar 24, 2023
Co-authored-by: Mattie Fu <[email protected]>
Co-authored-by: Mattie Fu <[email protected]>
Mariatta
reviewed
Mar 30, 2023
Mariatta
approved these changes
Mar 30, 2023
Co-authored-by: Mariatta Wijaya <[email protected]>
| @@ -54,3 +176,63 @@ def shard(self, shard_keys: "RowKeySamples" | None = None) -> list[ReadRowsQuery | |||
| query (if possible) | |||
| """ | |||
| raise NotImplementedError | |||
|
|
|||
| def to_dict(self) -> dict[str, Any]: | |||
There was a problem hiding this comment.
Please reconsider making dicts the primary api contract for methods.
There was a problem hiding this comment.
and if you stick with this, to_dict should probably be a an internal method
daniel-sanche
added a commit
that referenced
this pull request
Feb 5, 2024
* feat: add new v3.0.0 API skeleton (#745) * feat: improve rows filters (#751) * feat: read rows query model class (#752) * feat: implement row and cell model classes (#753) * feat: add pooled grpc transport (#748) * feat: implement read_rows (#762) * feat: implement mutate rows (#769) * feat: literal value filter (#767) * feat: row_exists and read_row (#778) * feat: read_modify_write and check_and_mutate_row (#780) * feat: sharded read rows (#766) * feat: ping and warm with metadata (#810) * feat: mutate rows batching (#770) * chore: restructure module paths (#816) * feat: improve timeout structure (#819) * fix: api errors apply to all bulk mutations * chore: reduce public api surface (#820) * feat: improve error group tracebacks on < py11 (#825) * feat: optimize read_rows (#852) * chore: add user agent suffix (#842) * feat: optimize retries (#854) * feat: add test proxy (#836) * chore(tests): add conformance tests to CI for v3 (#870) * chore(tests): turn off fast fail for conformance tets (#882) * feat: add TABLE_DEFAULTS enum for table method arguments (#880) * fix: pass None for retry in gapic calls (#881) * feat: replace internal dictionaries with protos in gapic calls (#875) * chore: optimize gapic calls (#863) * feat: expose retryable error codes to users (#879) * chore: update api_core submodule (#897) * chore: merge main into experimental_v3 (#900) * chore: pin conformance tests to v0.0.2 (#903) * fix: bulk mutation eventual success (#909) --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the RowQuery class, used to configure read_rows calls
Implementation is generally aligned with the Query class in the Java library
Implementation for sharding will come in a future PR
Note: This is merging into a new v3 branch, not main. I plan on making all PRs related to this rewrite to v3 and then merging v3 into main when development is complete