Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

structured logging: opt-in enable source location populating #690

Closed
minherz opened this issue Sep 27, 2021 · 2 comments
Closed

structured logging: opt-in enable source location populating #690

minherz opened this issue Sep 27, 2021 · 2 comments
Assignees
@minherz
Labels
api: logging Issues related to the googleapis/java-logging API. lang: java Issues specific to Java. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@minherz
Copy link
Contributor

minherz commented Sep 27, 2021

Is your feature request related to a problem? Please describe.
Populating source location (file name and line number) in Java is an operation that leads to performance penalties. Users should explicitly allow it.

Describe the solution you'd like
Provide a configuration to enable populating source location when structured logging is enabled.
@minherz minherz added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. lang: java Issues specific to Java. labels Sep 27, 2021
@minherz minherz self-assigned this Sep 27, 2021
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Sep 27, 2021
This was referenced Sep 27, 2021
Closed
Closed
Closed
Closed
Closed
@minherz
Copy link
Contributor Author

minherz commented Sep 27, 2021

Related issues #685, #686, #687, #688, #689, #690, #691

This was referenced Sep 27, 2021
Closed
Closed
Closed
Closed
Closed
@minherz
Copy link
Contributor Author

minherz commented Dec 15, 2021

Following the documented behavior the location information will be populated for log entries with the severity DEBUG or lower depending on the auto-population configuration (#689)

@minherz minherz closed this as completed Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@minherz minherz

Labels
api: logging Issues related to the googleapis/java-logging API. lang: java Issues specific to Java. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@minherz