Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

structured logging: add trace info discovery from Http request info #688

Closed
minherz opened this issue Sep 27, 2021 · 2 comments
Closed

structured logging: add trace info discovery from Http request info #688

minherz opened this issue Sep 27, 2021 · 2 comments
Assignees
Labels
api: logging Issues related to the googleapis/java-logging API. lang: java Issues specific to Java. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@minherz
Copy link
Contributor

minherz commented Sep 27, 2021

Is your feature request related to a problem? Please describe.
If not defined, the trace and spanId fields in LogEntry should be auto-populated when writing log entries to backend

Describe the solution you'd like
When Http request info is available and it has the X-Cloud-Trace-Context header, the tracing info should be retrieved (following the format) and populated.

@minherz minherz added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. lang: java Issues specific to Java. labels Sep 27, 2021
@minherz minherz self-assigned this Sep 27, 2021
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Sep 27, 2021
@minherz
Copy link
Contributor Author

minherz commented Sep 27, 2021

Related issues #685, #686, #687, #688, #689, #690, #691

@minherz
Copy link
Contributor Author

minherz commented Dec 5, 2021

The #687 implements capturing the tracing information in the Context class. The tracing info is captured from the Http servlet request based on W3C trace context header or Google Cloud trace context header. Alternatively, the information can be set manually using ContextHandler class.

@minherz minherz closed this as completed Dec 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. lang: java Issues specific to Java. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

1 participant