Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client_options to constructors for manual clients. #8475

Closed
19 tasks done
busunkim96 opened this issue Jun 25, 2019 · 2 comments
Closed
19 tasks done

Add client_options to constructors for manual clients. #8475

busunkim96 opened this issue Jun 25, 2019 · 2 comments
Assignees
Labels
api: automl Issues related to the AutoML API. api: bigquery Issues related to the BigQuery API. api: bigtable Issues related to the Bigtable API. api: clouderrorreporting Issues related to the Error Reporting API. api: cloudresourcemanager Issues related to the Resource Manager API. api: cloudtrace Issues related to the Cloud Trace API. api: datastore Issues related to the Datastore API. api: dns Issues related to the Cloud DNS API. api: firestore Issues related to the Firestore API. api: logging Issues related to the Cloud Logging API. api: pubsub Issues related to the Pub/Sub API. api: runtimeconfig Issues related to the Cloud Runtime Config API API. api: spanner Issues related to the Spanner API. api: storage Issues related to the Cloud Storage API. api: translation Issues related to the Cloud Translation API API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@busunkim96
Copy link
Contributor

busunkim96 commented Jun 25, 2019

List of clients is copied from the issue for client_info. See #7825.

The client_options constructor argument provides a consistent way for options to be set on clients. Currently only API Endpoint can be set with client_options.

GAPIC clients will gets this change via the generator, but the clients below need to be updated manually.

Clients that need client_options:

@busunkim96 busunkim96 added api: datastore Issues related to the Datastore API. api: storage Issues related to the Cloud Storage API. api: bigquery Issues related to the BigQuery API. api: dns Issues related to the Cloud DNS API. api: pubsub Issues related to the Pub/Sub API. api: bigtable Issues related to the Bigtable API. api: cloudresourcemanager Issues related to the Resource Manager API. api: logging Issues related to the Cloud Logging API. api: translation Issues related to the Cloud Translation API API. api: runtimeconfig Issues related to the Cloud Runtime Config API API. api: spanner Issues related to the Spanner API. api: clouderrorreporting Issues related to the Error Reporting API. api: cloudtrace Issues related to the Cloud Trace API. api: firestore Issues related to the Firestore API. api: automl Issues related to the AutoML API. labels Jun 25, 2019
@busunkim96 busunkim96 self-assigned this Jun 25, 2019
@sduskis
Copy link
Contributor

sduskis commented Jun 25, 2019

Cloud Bigtable (and maybe others) will need two different client_options, since it has a data and admin endpoint.

@tseaver
Copy link
Contributor

tseaver commented Jun 25, 2019

Spanner has three, accessed via: Client.instance_admin_api, Client.database_admin_api, Database.spanner_api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: automl Issues related to the AutoML API. api: bigquery Issues related to the BigQuery API. api: bigtable Issues related to the Bigtable API. api: clouderrorreporting Issues related to the Error Reporting API. api: cloudresourcemanager Issues related to the Resource Manager API. api: cloudtrace Issues related to the Cloud Trace API. api: datastore Issues related to the Datastore API. api: dns Issues related to the Cloud DNS API. api: firestore Issues related to the Firestore API. api: logging Issues related to the Cloud Logging API. api: pubsub Issues related to the Pub/Sub API. api: runtimeconfig Issues related to the Cloud Runtime Config API API. api: spanner Issues related to the Spanner API. api: storage Issues related to the Cloud Storage API. api: translation Issues related to the Cloud Translation API API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

4 participants