Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate: Add client options to translate_v2. #8737

Merged
merged 6 commits into from
Jul 30, 2019
Merged

Translate: Add client options to translate_v2. #8737

merged 6 commits into from
Jul 30, 2019

Conversation

busunkim96
Copy link
Contributor

Towards #8475.

@busunkim96 busunkim96 added the api: translation Issues related to the Cloud Translation API API. label Jul 23, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 23, 2019
@busunkim96 busunkim96 mentioned this pull request Jul 23, 2019
Closed
19 tasks
tseaver
tseaver suggested changes Jul 24, 2019
View reviewed changes
translate/google/cloud/translate_v2/_http.py Outdated Show resolved Hide resolved
translate/google/cloud/translate_v2/_http.py Outdated Show resolved Hide resolved
@busunkim96 busunkim96 mentioned this pull request Jul 24, 2019
Merged
@busunkim96 busunkim96 force-pushed the translate-client-options branch from 3be2555 to f5cb28c Compare July 29, 2019 17:24
@tseaver tseaver added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 29, 2019
tseaver
tseaver approved these changes Jul 29, 2019
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure seemed to be a race: google-cloud-core 1.0.3 wasn't yet available on PyPI. The docs job installs it from PyPI, rather than the local checkout.

@busunkim96 busunkim96 merged commit 3979e8b into googleapis:master Jul 30, 2019
@tseaver tseaver mentioned this pull request Oct 10, 2019
Closed
31 tasks
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
Add client options to translate_v2. (#8737)
ad886bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

Assignees
No one assigned
Labels
api: translation Issues related to the Cloud Translation API API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@busunkim96 @tseaver @googlebot @yoshi-kokoro