Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dns): add 'client_options' argument to client ctor #9516

Merged
merged 2 commits into from
Oct 22, 2019
Merged

feat(dns): add 'client_options' argument to client ctor #9516

merged 2 commits into from
Oct 22, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 22, 2019

Toward #8475

@tseaver tseaver added the api: dns Issues related to the Cloud DNS API. label Oct 22, 2019
@tseaver tseaver requested a review from busunkim96 as a code owner October 22, 2019 20:47
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 22, 2019
@busunkim96 busunkim96 mentioned this pull request Oct 22, 2019
Closed
19 tasks
@tseaver tseaver mentioned this pull request Oct 22, 2019
Closed
busunkim96
busunkim96 approved these changes Oct 22, 2019
View reviewed changes
dns/tests/unit/test_client.py Outdated Show resolved Hide resolved
dns/tests/unit/test_client.py Outdated Show resolved Hide resolved
@tseaver
test: use better bogus URLs
c930170 
Addresses review feedback
@tseaver tseaver requested a review from busunkim96 October 22, 2019 22:15
@tseaver tseaver merged commit 98639f8 into googleapis:master Oct 22, 2019
@tseaver tseaver deleted the 8475-dns-add-client_options-support branch October 22, 2019 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees
No one assigned
Labels
api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @busunkim96 @googlebot