Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Key name w/ slash quoted twice during upload #370

Closed
tseaver opened this issue Nov 12, 2014 · 0 comments · Fixed by #371
Closed

Key name w/ slash quoted twice during upload #370

tseaver opened this issue Nov 12, 2014 · 0 comments · Fixed by #371
Assignees
@tseaver
Labels
api: storage Issues related to the Cloud Storage API. 🚨 This issue needs some love. triage me I really want to be triaged.
Milestone
Storage Stable

Comments

@tseaver
Copy link
Contributor

tseaver commented Nov 12, 2014

The fix for #354 in #364 mistakenly quotes the Key.name when adding it the the query_params for the upload API call, but those params are already going to be quoted inside Connection.make_api_request (by way of urllib.urlencode).
@tseaver tseaver mentioned this issue Nov 12, 2014
Merged
tseaver added a commit that referenced this issue Nov 12, 2014
@tseaver
Merge pull request #371 from tseaver/370-doubly_quoted_name_in_upload
fe83520 
#370: Avoid extra URL-quoting of key name on upload.
@jgeewax jgeewax added the api: storage Issues related to the Cloud Storage API. label Jan 30, 2015
@jgeewax jgeewax added this to the Storage Stable milestone Jan 30, 2015
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 7, 2020
atulep pushed a commit that referenced this issue Apr 6, 2023
@gcf-owl-bot
chore(python): auto approve template changes (#370)
c471e0f 
Source-Link: googleapis/synthtool@453a5d9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:81ed5ecdfc7cac5b699ba4537376f3563f6f04122c4ec9e735d3b3dc1d43dd32
atulep pushed a commit that referenced this issue Apr 18, 2023
@gcf-owl-bot
chore(python): auto approve template changes (#370)
ee6b48a 
Source-Link: googleapis/synthtool@453a5d9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:81ed5ecdfc7cac5b699ba4537376f3563f6f04122c4ec9e735d3b3dc1d43dd32
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
chore(python): update .kokoro/requirements.txt (#370)
f9e74e7 
Source-Link: googleapis/synthtool@703554a
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:94961fdc5c9ca6d13530a6a414a49d2f607203168215d074cdb0a1df9ec31c0b
parthea pushed a commit that referenced this issue Jun 4, 2023
@gcf-owl-bot
feat: Adding database access information, such as queries field to a …
1f2f104 
…finding (#370)

* feat: Adding database access information, such as queries field to a finding. A database may be a sub-resource of an instance (as in the case of CloudSQL instances or Cloud Spanner instances), or the database instance itself

PiperOrigin-RevId: 469544940

Source-Link: googleapis/googleapis@a887434

Source-Link: googleapis/googleapis-gen@ca12635
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2ExMjYzNWUxYjA2NWRlOWVmY2FhNTUxNjY5NjQ4ZmNiZGUxYTk0NCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Jun 4, 2023
@bcoe
samples: move google_crc32c to be in sample (#370)
8356346
parthea pushed a commit that referenced this issue Jul 6, 2023
@renovate-bot
chore(deps): update dependency numpy to v1.23.3 (#370)
e0e9609
parthea pushed a commit that referenced this issue Sep 20, 2023
@renovate-bot
chore(deps): update dependency google-cloud-retail to v1.11.0 (#370)
a8a601f
vchudnov-g pushed a commit that referenced this issue Sep 20, 2023
@galz10 @parthea
docs(samples): add set agent code sample (#370)
038d9bb 
* Added Update Intent Snippet and Test

* Deleted Setting Env Vars

* Fixed Lint Issues

* Fixed Lint and Build Issue

* Fixed Build Issue

* Changed tests to pytests

* Removed delete and create agent from test

* Fixed Import Order

* Deleted unused import

* Removed Language from update_intent Snippet

* Added copyright

* Changed intent name to random name

* delete intent after testing

* fix test

* remove contains

* Added Create Intent

* fix lint

* docs(samples): add set agent code sample

* lint fix

* Resolved comments

* test and lint changes

* Added Comments

* lint fix

Co-authored-by: Anthonios Partheniou <[email protected]>
parthea added a commit that referenced this issue Sep 22, 2023
@renovate-bot @gcf-owl-bot @parthea
chore(deps): update all dependencies (#370)
6377a40 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this issue Sep 22, 2023
@release-please
chore(main): release 2.14.2 (#370)
509bac7 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Sep 22, 2023
@gcf-owl-bot
build(deps): bump requests to 2.31.0 [autoapprove] (#370)
88a68ce 
Source-Link: https://togithub.com/googleapis/synthtool/commit/30bd01b4ab78bf1b2a425816e15b3e7e090993dd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
chore: update copyright year to 2022 (#370)
8e3cb54 
* chore: update copyright year to 2022

PiperOrigin-RevId: 431037888

Source-Link: googleapis/googleapis@b3397f5

Source-Link: googleapis/googleapis-gen@510b54e
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTEwYjU0ZTFjZGVmZDUzMTczOTg0ZGYxNjY0NTA4MTMwOGZlODk3ZSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@m-strzelczyk @gcf-owl-bot
cleanup(samples): Samples moved to python-docs-samples repo (#370)
830fd49 
* cleanup(samples): Samples moved to python-docs-samples repo

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Adding README pointing to new location

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
docs: Fix formatting of request arg in docstring (#370)
e9b00d7 
* docs: Fix formatting of request arg in docstring

chore: Update gapic-generator-python to v1.9.1
PiperOrigin-RevId: 518604533

Source-Link: googleapis/googleapis@8a085ae

Source-Link: googleapis/googleapis-gen@b2ab4b0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
docs: Add documentation for enums (#370)
0f53728 
* docs: Add documentation for enums

fix: Add context manager return types

chore: Update gapic-generator-python to v1.8.1
PiperOrigin-RevId: 503210727

Source-Link: googleapis/googleapis@a391fd1

Source-Link: googleapis/googleapis-gen@0080f83
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDA4MGY4MzBkZWMzN2MzMzg0MTU3MDgyYmNlMjc5ZTM3MDc5ZWE1OCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this issue Oct 21, 2023
@gcf-owl-bot
build(deps): [autoapprove] bump cryptography from 41.0.0 to 41.0.2 (#370
06b79e1 
)

Source-Link: https://togithub.com/googleapis/synthtool/commit/d6103f4a3540ba60f633a9e25c37ec5fe7e6286d
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:39f0f3f2be02ef036e297e376fe3b6256775576da8a6ccb1d5eeb80f4c8bf8fb
parthea pushed a commit that referenced this issue Oct 21, 2023
@nayaknishant
chore: format update to README.rst (#370)
3e7b346 
* chore: small update to README.rst

* Update README.rst

* Update README.rst
parthea pushed a commit that referenced this issue Oct 21, 2023
@renovate-bot
chore(deps): update dependency pytest to v7.2.1 (#370)
71b691e
parthea pushed a commit that referenced this issue Oct 22, 2023
@gcf-owl-bot
chore(python): auto approve template changes (#370)
2faf8fc 
Source-Link: googleapis/synthtool@453a5d9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:81ed5ecdfc7cac5b699ba4537376f3563f6f04122c4ec9e735d3b3dc1d43dd32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: storage Issues related to the Cloud Storage API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
Storage Stable
Development

Successfully merging a pull request may close this issue.

#370: Avoid extra URL-quoting of key name on upload.
3 participants
@jgeewax @tseaver @yoshi-automation