Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #354: support slash in key names #364

Merged
merged 2 commits into from
Nov 11, 2014
Merged

Fix #354: support slash in key names #364

merged 2 commits into from
Nov 11, 2014

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 10, 2014

Quote 'key.name' properly when used in URL path / query string.

Fixes #354.

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. labels Nov 10, 2014
@tseaver tseaver mentioned this pull request Nov 10, 2014
Closed
dhermes
dhermes reviewed Nov 10, 2014
View reviewed changes
gcloud/storage/key.py
query_params = {
'uploadType': 'resumable',
'name': urllib.quote_plus(self.name),
}

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d4409f4 on tseaver:354-support_slash_in_key_names into * on GoogleCloudPlatform:master*.

dhermes
dhermes reviewed Nov 10, 2014
View reviewed changes
pylintrc_default
@@ -24,7 +24,8 @@ ignore = datastore_v1_pb2.py
disable = I, protected-access, maybe-no-member, no-member,
redefined-builtin, star-args, missing-format-attribute,
similarities, arguments-differ,
too-many-public-methods, too-few-public-methods
too-many-public-methods, too-few-public-methods,
too-many-locals, too-many-lines, too-many-instance-attributes

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7de8081 on tseaver:354-support_slash_in_key_names into * on GoogleCloudPlatform:master*.

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 10, 2014
@tseaver tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 11, 2014
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling a7898da on tseaver:354-support_slash_in_key_names into 95e80e1 on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor Author

tseaver commented Nov 11, 2014

@dhermes rebased.

@dhermes
Copy link
Contributor

dhermes commented Nov 11, 2014

LGTM

tseaver added a commit that referenced this pull request Nov 11, 2014
@tseaver
Merge pull request #364 from tseaver/354-support_slash_in_key_names
bc8b1c4 
Fix #354: support slash in key names
@tseaver tseaver merged commit bc8b1c4 into googleapis:master Nov 11, 2014
This was referenced Nov 12, 2014
Merged
Closed
@tseaver tseaver deleted the 354-support_slash_in_key_names branch February 6, 2015 18:43
urshala pushed a commit to urshala/google-cloud-python that referenced this pull request Jan 17, 2020
Protocol timezone parameter now accepts strings (googleapis#364)
12a4e4c
atulep pushed a commit that referenced this pull request Apr 6, 2023
@gcf-owl-bot
chore(python): use ubuntu 22.04 in docs image (#364)
7537b92 
Source-Link: googleapis/synthtool@f15cc72
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd
atulep pushed a commit that referenced this pull request Apr 18, 2023
@gcf-owl-bot
chore(python): use ubuntu 22.04 in docs image (#364)
dd86edf 
Source-Link: googleapis/synthtool@f15cc72
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd
parthea pushed a commit that referenced this pull request Jun 4, 2023
@renovate-bot
chore(deps): update dependency google-cloud-documentai to v2 (#364)
b0bbf7a
parthea added a commit that referenced this pull request Jun 4, 2023
@parthea
fix(deps): allow protobuf 3.19.5 (#364)
4dbbaf9 
* fix(deps): allow protobuf 3.19.5

* explicitly exclude protobuf 4.21.0
parthea pushed a commit that referenced this pull request Sep 20, 2023
@release-please
chore(main): release 1.11.0 (#364)
f01d09c 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@gcf-owl-bot
feat: expose Locations service to get/list avaliable locations of D…
d5d18a6 
…ialogflow products (#364)

PiperOrigin-RevId: 389905442

Source-Link: googleapis/googleapis@4c984f3

Source-Link: googleapis/googleapis-gen@ea3337a

feat: add language code to streaming recognition result
feat: add time zone and security settings to conversation profile
docs: fix validation result docs
docs: update environment docs
docs: update agent docs 
docs: update entity type docs 
docs: update intent docs
parthea added a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot @parthea
fix: require python 3.7+ (#364)
63c1af9 
* chore(python): drop python 3.6

Source-Link: googleapis/synthtool@4f89b13
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c

* require python 3.7+ in setup.py

* remove python 3.6 sample configs

* update api_description in repo-metadata

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@release-please
chore(main): release 2.19.0 (#364)
358ca84 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): upgrade gcp-releasetool in .kokoro [autoapprove] (#364)
1d31bec 
Source-Link: https://togithub.com/googleapis/synthtool/commit/5f2a6089f73abf06238fe4310f6a14d6f6d1eed3
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): exclude setup.py in renovate config (#364)
a324cfc 
Source-Link: googleapis/synthtool@56da63e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:993a058718e84a82fda04c3177e58f0a43281a996c7c395e0a56ccc4d6d210d7

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: use gapic-generator-python 0.62.1 (#364)
6dfc549 
- [x] Regenerate this pull request now.

fix: resolve DuplicateCredentialArgs error when using credentials_file

committer: parthea
PiperOrigin-RevId: 425964861

Source-Link: googleapis/googleapis@84b1a5a

Source-Link: googleapis/googleapis-gen@4fb761b
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGZiNzYxYmJkODUwNmFjMTU2ZjQ5YmFjNWYxODMwNmFhOGViM2FhOCJ9
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): update release script dependencies (#364)
f1b2f91 
Source-Link: googleapis/synthtool@25083af
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e6cbd61f1838d9ff6a31436dfc13717f372a7482a82fc1863ca954ec47bff8c8

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@release-please
chore(main): release 2.12.0 (#364)
bdacbf5 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea added a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot @parthea
fix(deps): Require google-api-core >=1.34.0, >=2.11.0 (#364)
a4c956b 
* fix(deps): Require google-api-core >=1.34.0, >=2.11.0

fix: Drop usage of pkg_resources

fix: Fix timeout default values

docs(samples): Snippetgen should call await on the operation coroutine before calling result

PiperOrigin-RevId: 493260409

Source-Link: googleapis/googleapis@fea4387

Source-Link: googleapis/googleapis-gen@387b734
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMzg3YjczNDRjNzUyOWVlNDRiZTg0ZTYxM2IxOWE4MjA1MDhjNjEyYiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* add gapic_version.py

* add gapic_version.py

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): add E231 to .flake8 ignore list (#364)
fe1510b 
Source-Link: googleapis/synthtool@7ff4aad
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:462782b0b492346b2d9099aaff52206dd30bc8e031ea97082e6facecc2373244
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-analytics-data to v0.16.3 (#364)
f083f9e
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): update .pre-commit-config.yaml to use black==22.3.0 (#364
98495ec 
)

Source-Link: googleapis/synthtool@7804ade
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:eede5672562a32821444a8e803fb984a6f61f2237ea3de229d2de24453f4ae7d
parthea pushed a commit that referenced this pull request Oct 21, 2023
@renovate-bot
chore(deps): update dependency google-cloud-build to v3.10.0 (#364)
395549a
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
chore(python): use ubuntu 22.04 in docs image (#364)
0296efc 
Source-Link: googleapis/synthtool@f15cc72
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:bc5eed3804aec2f05fad42aacf973821d9500c174015341f721a984a0825b6fd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not "get_contents_as_*" when key is in a folder
3 participants
@tseaver @coveralls @dhermes