Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#370: Avoid extra URL-quoting of key name on upload. #371

Merged
merged 1 commit into from
Nov 12, 2014
Merged

#370: Avoid extra URL-quoting of key name on upload. #371

merged 1 commit into from
Nov 12, 2014

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 12, 2014

Fixes #370.

@tseaver tseaver added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: storage Issues related to the Cloud Storage API. labels Nov 12, 2014
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 580c082 on tseaver:370-doubly_quoted_name_in_upload into cf0fca0 on GoogleCloudPlatform:master.

@dhermes
Copy link
Contributor

dhermes commented Nov 12, 2014

LGTM

How did you notice this?

Is it worth adding a regression test?

@tseaver
Copy link
Contributor Author

tseaver commented Nov 12, 2014

Bug found while working on using pseudo-hierarchical keys in https://github.com/GoogleCloudPlatform/gcloud-python-expenses-demo

@tseaver
Copy link
Contributor Author

tseaver commented Nov 12, 2014

I think a regression test which exercises "pseudo hierachical" keys would be useful.

tseaver added a commit that referenced this pull request Nov 12, 2014
@tseaver
Merge pull request #371 from tseaver/370-doubly_quoted_name_in_upload
fe83520 
#370: Avoid extra URL-quoting of key name on upload.
@tseaver tseaver merged commit fe83520 into googleapis:master Nov 12, 2014
@tseaver tseaver deleted the 370-doubly_quoted_name_in_upload branch November 12, 2014 02:19
@tseaver
Copy link
Contributor Author

tseaver commented Nov 12, 2014

See: https://github.com/GoogleCloudPlatform/gcloud-python-expenses-demo/blob/f0045389b21125c89149e55ad80835a59cf3ee5e/gcloud_expenses/__init__.py#L223-L246

@dhermes dhermes mentioned this pull request Nov 12, 2014
Closed
atulep pushed a commit that referenced this pull request Apr 3, 2023
@gcf-owl-bot
feat: Add adaptation proto for v1 api (#371)
0d9b246 
* feat: Add adaptation proto for v1 api

PiperOrigin-RevId: 447561222

Source-Link: googleapis/googleapis@ec9193e

Source-Link: googleapis/googleapis-gen@cd279b0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2QyNzliMDAzZTQ0NTVjOWI4MDVmMjJmYzNiOTk3NmFkODYzOWVlNiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
@gcf-owl-bot
feat: Add adaptation proto for v1 api (#371)
3d54d7a 
* feat: Add adaptation proto for v1 api

PiperOrigin-RevId: 447561222

Source-Link: googleapis/googleapis@ec9193e

Source-Link: googleapis/googleapis-gen@cd279b0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2QyNzliMDAzZTQ0NTVjOWI4MDVmMjJmYzNiOTk3NmFkODYzOWVlNiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
@gcf-owl-bot
feat: Add adaptation proto for v1 api (#371)
b33a1d8 
* feat: Add adaptation proto for v1 api

PiperOrigin-RevId: 447561222

Source-Link: googleapis/googleapis@ec9193e

Source-Link: googleapis/googleapis-gen@cd279b0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2QyNzliMDAzZTQ0NTVjOWI4MDVmMjJmYzNiOTk3NmFkODYzOWVlNiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 18, 2023
@gcf-owl-bot
feat: Add adaptation proto for v1 api (#371)
a33bdeb 
* feat: Add adaptation proto for v1 api

PiperOrigin-RevId: 447561222

Source-Link: googleapis/googleapis@ec9193e

Source-Link: googleapis/googleapis-gen@cd279b0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2QyNzliMDAzZTQ0NTVjOWI4MDVmMjJmYzNiOTk3NmFkODYzOWVlNiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@release-please
chore(main): release 1.15.0 (#371)
66448fa 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jul 6, 2023
@gcf-owl-bot
chore: use gapic generator python 1.4.1 (#371)
7797d05 
* fix: integrate  gapic-generator-python-1.4.1 and enable more py_test targets

PiperOrigin-RevId: 473833416

Source-Link: googleapis/googleapis@565a550

Source-Link: googleapis/googleapis-gen@1ee1a06
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMWVlMWEwNmM2ZGUzY2E4Yjg0MzU3MmMxZmRlMDU0OGY4NDIzNjk4OSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 20, 2023
@gcf-owl-bot
feat: support async write mode for WriteUserEvent API (#371)
9f16a27 
* feat: support async write mode for WriteUserEvent API
feat: support collect GA4 event format with prebuilt whistle rule
feat: support exact searchable and retrievable in catalog attribute config
feat: deprecate retrievable_fields in product attribute
feat: support diversity type in serving config
docs: keep the API doc up-to-date with recent changes

PiperOrigin-RevId: 495660792

Source-Link: googleapis/googleapis@0dbe50f

Source-Link: googleapis/googleapis-gen@59b8ced
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNTliOGNlZDA2NmJhMTk2NTdlMDZkNzhjMjAxZTYyMGNhNmFiNzljMiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
build(deps): [autoapprove] bump certifi from 2022.12.7 to 2023.7.22 (#…
4f30aa0 
…371)

Source-Link: https://togithub.com/googleapis/synthtool/commit/395d53adeeacfca00b73abf197f65f3c17c8f1e9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6c1cbc75c74b8bdd71dada2fa1677e9d6d78a889e9a70ee75b93d1d0543f96e1
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
build(deps): bump requests to 2.31.0 [autoapprove] (#371)
607a620 
Source-Link: https://togithub.com/googleapis/synthtool/commit/30bd01b4ab78bf1b2a425816e15b3e7e090993dd
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:9bc5fa3b62b091f60614c08a7fb4fd1d3e1678e326f34dd66ce1eefb5dc3267b
parthea added a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot @parthea
fix(deps): require protobuf >= 3.20.2 (#371)
0a4f82f 
* chore: exclude requirements.txt file from renovate-bot

Source-Link: googleapis/synthtool@f58d313
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:7a40313731a7cb1454eef6b33d3446ebb121836738dc3ab3d2d3ded5268c35b6

* update constraints files

* fix(deps): require protobuf 3.20.2

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <[email protected]>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@release-please
chore(main): release 2.12.1 (#371)
1ebffc6 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@release-please
chore(main): release 2.14.1 (#371)
20e13b7 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
build: [autoapprove] bump cryptography from 41.0.2 to 41.0.3 (#371)
eb16816 
Source-Link: https://togithub.com/googleapis/synthtool/commit/352b9d4c068ce7c05908172af128b294073bf53c
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:3e3800bb100af5d7f9e810d48212b37812c1856d20ffeafb99ebe66461b61fc7
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
build(deps): [autoapprove] bump pygments from 2.13.0 to 2.15.0 (#371)
915a7e9 
Source-Link: https://togithub.com/googleapis/synthtool/commit/eaef28efd179e6eeb9f4e9bf697530d074a6f3b9
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:f8ca7655fa8a449cadcabcbce4054f593dcbae7aeeab34aa3fcc8b5cf7a93c9e
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(python): add license header to auto-label.yaml (#371)
2dc37c1 
Source-Link: googleapis/synthtool@eb78c98
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8a5d3f6a2e43ed8293f34e06a2f56931d1e88a2694c3bb11b15df4eb256ad163
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
docs: Add documentation for enums (#371)
06402ca 
* docs: Add documentation for enums

fix: Add context manager return types

chore: Update gapic-generator-python to v1.8.1
PiperOrigin-RevId: 503210727

Source-Link: googleapis/googleapis@a391fd1

Source-Link: googleapis/googleapis-gen@0080f83
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDA4MGY4MzBkZWMzN2MzMzg0MTU3MDgyYmNlMjc5ZTM3MDc5ZWE1OCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
feat: Add adaptation proto for v1 api (#371)
44c478d 
* feat: Add adaptation proto for v1 api

PiperOrigin-RevId: 447561222

Source-Link: googleapis/googleapis@ec9193e

Source-Link: googleapis/googleapis-gen@cd279b0
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2QyNzliMDAzZTQ0NTVjOWI4MDVmMjJmYzNiOTk3NmFkODYzOWVlNiJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Key name w/ slash quoted twice during upload
3 participants
@tseaver @coveralls @dhermes