Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHANGE ME] Re-generated Spanner to pick up changes in the API or client library generator. #2713

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

yoshi-automation
Copy link
Contributor

This PR was generated using Autosynth. 🌈

Commits in this repo since last synth:
bf173da test: fix system tests (#2709)
80e785c chore: update metadata (#2707)
b367012 docs: update documentation (#2702)
6a5c496 chore: update metadata (#2700)
b0411aa feat: add autoscaling policy client for v1 API (#2662)
13983d5 feat!: move $languageCode to optional args (#2691)
7ec7e88 feat: update timeout and retry configuration (#2693)
7062ba9 docs: update documentation (#2694)
675ec72 docs: update documentation (#2695)
3adb76e chore: release 0.125.0 (#2661)
42ad09a test: fix broken system test (#2688)
4418059 feat: add ServiceMonitoringServiceClient; update clients (#2668)
d89b430 feat: update required version of google/cloud-core (#2687)
d8cd161 feat: add getPrivateProperty test helper (#2686)
bc27230 fix: update metadata (#2680)
f6884af feat: introduce security center v1p1beta1 (#2681)
081fc94 feat: update timeouts and documentation (#2683)
f54af5d feat!: update client method signatures and deprecate old proper… (#2684)
ac533e9 chore: update metadata (#2685)
e8b60da feat: add cmek methods and sink description and disabled toggle (#2678)
57d05f1 feat!: rename formatting method and update listGroupStats signa… (#2677)
49a7ecc revert: fix breaking change in errorreporting gapic (#2665) (#2675)
999b1a7 feat: add instance connect mode and upgrade instance method (#2674)
ad03e78 feat: add bigquery options and exclusion, metric and sink creat… (#2673)
ddc58ee feat: support iam conditions (#2416)
3170002 feat!: update clients (#2669)
516844b chore: exclude unversioned protos (#2672)
e6308a6 feat: inject database info on list databases (#2656)
b16dd8b chore: update metadata and internal logic (#2671)
5935ea9 chore: run synth fixes on unversioned protos (#2660)
03219fd chore: fix breaking change in errorreporting gapic (#2665)
a1ca072 chore: fix backwards compatibility via synth (#2664)
cc6a210 feat: add uri_prefix to gcs destination (#2638)
a074815 feat: update clients (#2651)
e6bc83c chore: update internal logic (#2639)
541b20e feat: update clients (#2640)
a83e186 chore: update internal logic (#2641)
db61ef5 chore: update internal logic (#2642)
147fdf4 fix: update documentation (#2645)
9154837 fix: update documentation (#2663)
86dc948 fix: update metadata (#2646)
3e5151a chore: fix scheduler breaking change (#2659)
a6e31ae feat: add client id to streaming pull config (#2657)
eb4d88d chore: release 0.124.0 (#2637)
0f8bd09 feat: add support for dead letter policies (#2504)
65c24d7 feat: introduce recommender v1 client (#2636)
97a3904 fix: update documentation (#2653)
5790d1a feat: add support for ordering keys (#2624)
1bb6167 feat: update dialogflow clients (#2623)
e525929 chore: fix proto messages (#2612)
f60e159 revert: revert "refactor: update spanner lroResponseMappers to map types for metadata and response separately" (#2585)
3425da1 refactor: update spanner lroMappers to map types for metadata and response separately (#2537)
3bf8b7b chore: release 0.123.0 (#2569)
75b94bc feat: add Secret Manager (#2583)
79e9dc7 fix: update rest transport URI bindings (#2527)
39035fe feat: introduce secret manager client (#2582)
0e6da4d fix: update metadata (#2543)
6ad24c1 fix: update metadata and documentation (#2574)
c18cc32 feat: update v1pv1beta1 timeouts (#2576)
2fa7fd8 feat: update SecurityCenter client (#2567)
ff460df chore: update synth replacements to fix copyright dates (#2570)
fe62c50 feat: add external protection level, update documentation (#2538)
38aaa4d docs: update documentation (#2545)
7df9ce0 docs: update documentation (#2546)
87b309d fix: add tests for dataset and model encryption config (#2377)
7d435e7 chore: release 0.122.0 (#2533)
aef45e7 fix: allow mkdir() via stream wrapper when UBL is enabled (#2541)
006487a feat: enable 'FieldMask' param in Instance::reload() method options (#2530)
bb0e3d9 feat: add support for ARCHIVE storage class (#2428)
ca739c4 fix: fix compatibility with phpspec/prophecy v1.10 (#2525)
ff43ecd chore: release 0.121.0 (#2508)
e80f302 feat: add bigquery destination, update GCS destination, support Real Time Feed API (#2463)
e9e9090 docs: update documentation (#2517)
a0e304b docs: update documentation (#2515)
67f0029 fix: fix is_dir() and scandir() behavior in stream wrapper (#2496)
b2c946f docs: update documentation (#2513)
f7bd9f7 fix: make vision test more resilient (#2512)
a9722bb fix: update unit tests (#2487)
0c546ac chore: update metadata (#2506)
4b9377f feat: update timeouts (#2505)
0065969 fix: add http annotations for operations (#2488)
428b927 docs: update documentation (#2510)
a9717f2 docs: update documentation (#2509)
1ed49dd feat: add locationId to request messages (#2489)
c5b25d4 feat: update client (#2507)
331799f fix: demonstrate row key in sample (#2501)
cb280a7 fix: add back in HTTP bindings for operation calls (#2495)
e549d23 docs: update documentation (#2502)
b3c2f7e docs: update documentation (#2499)
3e3189a chore: release 0.120.0 (#2482)
3926eaf feat: update metadata, documentation and rest configuration. (#2477)
b977437 feat: add speaker tag to wordinfo and update timeouts (#2481)
0214362 chore: release 0.119.0 (#2461)

Log from Synthtool
synthtool > Executing /tmpfs/src/git/autosynth/working_repo/Spanner/synth.py.
On branch autosynth-spanner
nothing to commit, working tree clean
HEAD detached at FETCH_HEAD
nothing to commit, working tree clean
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:6aec9c34db0e4be221cdaf6faba27bdc07cfea846808b3d3b964dfce3a9a0f9b
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/spanner/artman_spanner.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-spanner-v1.
synthtool > Running generator for google/spanner/admin/database/artman_spanner_admin_database.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-spanner-admin-database-v1.
synthtool > Running generator for google/spanner/admin/instance/artman_spanner_admin_instance.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/php/google-cloud-spanner-admin-instance-v1.
synthtool > Replaced "'serviceAddress' =>" in src/Admin/Instance/V1/Gapic/InstanceAdminGapicClient.php.
synthtool > Replaced "'serviceAddress' =>" in src/Admin/Database/V1/Gapic/DatabaseAdminGapicClient.php.
synthtool > Replaced "'serviceAddress' =>" in src/V1/Gapic/SpannerGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress\\n\\s+\\*\\s+The address' in src/Admin/Instance/V1/Gapic/InstanceAdminGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress\\n\\s+\\*\\s+The address' in src/Admin/Database/V1/Gapic/DatabaseAdminGapicClient.php.
synthtool > Replaced '@type string \\$serviceAddress\\n\\s+\\*\\s+The address' in src/V1/Gapic/SpannerGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/Admin/Instance/V1/Gapic/InstanceAdminGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/Admin/Database/V1/Gapic/DatabaseAdminGapicClient.php.
synthtool > Replaced '\\$transportConfig, and any \\$serviceAddress' in src/V1/Gapic/SpannerGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/Admin/Instance/V1/Gapic/InstanceAdminGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/Admin/Database/V1/Gapic/DatabaseAdminGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in src/V1/Gapic/SpannerGapicClient.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/SpannerClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/V1/SpannerClientPartialVeneerTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/Admin/Instance/V1/InstanceAdminClientTest.php.
synthtool > Replaced 'Copyright \\d{4}' in tests/Unit/Admin/Database/V1/DatabaseAdminClientTest.php.
synthtool > Replaced 'namespace Google\\\\Cloud\\\\Spanner\\\\Admin\\\\Database\\\\Tests\\\\Unit' in tests/Unit/Admin/Database/V1/DatabaseAdminClientTest.php.
synthtool > Replaced 'namespace Google\\\\Cloud\\\\Spanner\\\\Admin\\\\Instance\\\\Tests\\\\Unit' in tests/Unit/Admin/Instance/V1/InstanceAdminClientTest.php.
synthtool > Replaced '@group database' in tests/Unit/Admin/Database/V1/DatabaseAdminClientTest.php.
synthtool > Replaced '@group instance' in tests/Unit/Admin/Instance/V1/InstanceAdminClientTest.php.
synthtool > Replaced 'public\\ function\\ commit\\(\\$session\\,\\ array\\ \\$optionalArgs\\ \\=\\ \\[\\]\\)' in src/V1/Gapic/SpannerGapicClient.php.
synthtool > Replaced "if\\ \\(isset\\(\\$optionalArgs\\[\\'mutations\\'\\]\\)\\)\\ \\{\\\n\\ \\ \\ \\ \\ \\ \\ \\ \\ \\ \\ \\ \\$request\\-\\>setMutations\\(\\$optionalArgs\\[\\'mutations\\'\\]\\)\\;\\\n\\ \\ \\ \\ \\ \\ \\ \\ \\}\\\n" in src/V1/Gapic/SpannerGapicClient.php.
synthtool > Replaced "\\$formattedSession\\ \\=\\ \\$spannerClient\\-\\>sessionName\\(\\'\\[PROJECT\\]\\'\\,\\ \\'\\[INSTANCE\\]\\'\\,\\ \\'\\[DATABASE\\]\\'\\,\\ \\'\\[SESSION\\]\\'\\)\\;\\\n\\ \\ \\ \\ \\ \\*\\ \\ \\ \\ \\ \\$response\\ \\=\\ \\$spannerClient\\-\\>commit\\(\\$formattedSession\\)\\;" in src/V1/Gapic/SpannerGapicClient.php.
synthtool > Replaced '\\@type\\ Mutation\\[\\]\\ \\$mutations\\\n\\ \\ \\ \\ \\ \\*\\ \\ \\ \\ \\ \\ \\ \\ \\ \\ The\\ mutations\\ to\\ be\\ executed\\ when\\ this\\ transaction\\ commits\\.\\ All\\\n\\ \\ \\ \\ \\ \\*\\ \\ \\ \\ \\ \\ \\ \\ \\ \\ mutations\\ are\\ applied\\ atomically\\,\\ in\\ the\\ order\\ they\\ appear\\ in\\\n\\ \\ \\ \\ \\ \\*\\ \\ \\ \\ \\ \\ \\ \\ \\ \\ this\\ list\\.\\\n\\ \\ \\ \\ \\ \\*\\ \\ \\ \\ \\ ' in src/V1/Gapic/SpannerGapicClient.php.
synthtool > Replaced '\\@param\\ string\\ \\$session\\ \\ \\ \\ \\ \\ Required\\.\\ The\\ session\\ in\\ which\\ the\\ transaction\\ to\\ be\\ committed\\ is\\ running\\.\\\n\\ \\ \\ \\ \\ \\*\\ \\@param\\ array\\ \\ \\$optionalArgs\\ \\{' in src/V1/Gapic/SpannerGapicClient.php.
synthtool > Replaced '\\$response\\ \\=\\ \\$client\\-\\>commit\\(\\$formattedSession\\)\\;' in tests/Unit/V1/SpannerClientTest.php.
synthtool > Replaced '\\$client\\-\\>commit\\(\\$formattedSession\\)\\;' in tests/Unit/V1/SpannerClientTest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/GetSessionRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/RollbackRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/PartialResultSet.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ListSessionsResponse.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ExecuteBatchDmlRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/Transaction.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/KeySet.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ExecuteSqlRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/BatchCreateSessionsRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ListSessionsRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ResultSetMetadata.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/CommitRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/Session.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ReadRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/DeleteSessionRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/PartitionReadRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/PlanNode.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/CreateSessionRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ResultSetStats.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/PartitionQueryRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/PartitionResponse.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/BeginTransactionRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ResultSet.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ExecuteBatchDmlResponse.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/CommitResponse.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/Type.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/PartitionOptions.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/Partition.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/TransactionOptions/ReadOnly.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/ExecuteBatchDmlRequest/Statement.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/StructType/Field.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/Mutation/Write.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/Mutation/Delete.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/PlanNode/ShortRepresentation.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/V1/PlanNode/ChildLink.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Instance/V1/ListInstancesResponse.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Instance/V1/GetInstanceRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Instance/V1/ListInstanceConfigsRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Instance/V1/GetInstanceConfigRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Instance/V1/UpdateInstanceMetadata.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Instance/V1/Instance.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Instance/V1/InstanceConfig.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Instance/V1/ListInstanceConfigsResponse.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Instance/V1/DeleteInstanceRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Instance/V1/ListInstancesRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Instance/V1/CreateInstanceRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Instance/V1/UpdateInstanceRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Instance/V1/CreateInstanceMetadata.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Instance/V1/ReplicaInfo.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Database/V1/CreateDatabaseRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Database/V1/UpdateDatabaseDdlMetadata.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Database/V1/GetDatabaseDdlRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Database/V1/GetDatabaseRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Database/V1/CreateDatabaseMetadata.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Database/V1/ListDatabasesResponse.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Database/V1/UpdateDatabaseDdlRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Database/V1/Database.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Database/V1/ListDatabasesRequest.php.
synthtool > Replaced 'Generated from protobuf field ([^\\n]{0,})\\n\\s{5}\\*/\\n\\s{4}protected \\$' in src/Admin/Database/V1/DropDatabaseRequest.php.
synthtool > No replacements made in src/**/V*/**/*.php for pattern final class, maybe replacement is no longer needed?
synthtool > No replacements made in src/**/V*/**/*.php for pattern public function ([s|g]\w{3,})Unwrapped, maybe replacement is no longer needed?
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: spanner Issues related to the Spanner API. label Feb 21, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2020
@jdpedrie
Copy link
Contributor

@skuruppu in the future, please don't merge over failing checks. Commit messages must follow conventional commits in order to properly work with our release tool. Feel free to reach out offline if you've got more questions, happy to help make sure we're on the same page.

@skuruppu
Copy link
Contributor

skuruppu commented Mar 3, 2020

@skuruppu in the future, please don't merge over failing checks. Commit messages must follow conventional commits in order to properly work with our release tool. Feel free to reach out offline if you've got more questions, happy to help make sure we're on the same page.

Thanks for noting this. I thought it might be ok if it's the tooling that generated the commits but that's fair that we don't want to allow that. I will 'cc you the next time this happens and ask for help on fixing these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants