fix: fix compatibility with phpspec/prophecy v1.10 #2525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
dwsupplee
approved these changes
Dec 18, 2019
dwsupplee
changed the title
This was referenced Jan 15, 2020
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 18, 2020
Closed
Closed
Closed
Closed
Closed
This was referenced Jan 28, 2020
Merged
Closed
Closed
Closed
Merged
Closed
This was referenced Feb 4, 2020
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest update to prophecy broke our Spanner tests. Prophecy now evaluates expectations later in execution, and started to notice that
Database::__destruct()was callingConnectionInterface::deleteSession()even though we didn't say it would.This change adds a utility trait to create connection stubs with the globally-expected method calls already enqueued.