fix: pubsub ack regression test - empty message #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM! |
stephenplusplus
added a commit
that referenced
this pull request
Nov 24, 2014
fix: pubsub ack regression test - empty message
chingor13
pushed a commit
that referenced
this pull request
Aug 22, 2022
sofisl
pushed a commit
that referenced
this pull request
Sep 27, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Oct 12, 2022
This was referenced Oct 12, 2022
sofisl
pushed a commit
that referenced
this pull request
Oct 13, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 9, 2022
This was referenced Nov 9, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 10, 2022
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
* updated CHANGELOG.md [ci skip] * updated package.json [ci skip] * updated samples/package.json [ci skip]
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
- [ ] Regenerate this pull request now. PiperOrigin-RevId: 392067151 Source-Link: googleapis/googleapis@06345f7 Source-Link: googleapis/googleapis-gen@95882b3
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [2.3.0](https://www.github.com/googleapis/nodejs-datalabeling/compare/v2.2.7...v2.3.0) (2021-08-23) ### Features * turns on self-signed JWT feature flag ([#307](https://www.github.com/googleapis/nodejs-datalabeling/issues/307)) ([adbe0cd](https://www.github.com/googleapis/nodejs-datalabeling/commit/adbe0cdef6538df9055a5e5039161e5a680cb336)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
* docs(samples): add example tags to generated samples PiperOrigin-RevId: 408439482 Source-Link: googleapis/googleapis@b9f6184 Source-Link: googleapis/googleapis-gen@eb888bc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWI4ODhiYzIxNGVmYzdiZjQzYmY0NjM0YjQ3MDI1NDU2NWE2NTlhNSJ9 * 🦉 Updates from OwlBot See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
* chore(main): release 3.1.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
This was referenced Nov 11, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release *beep* *boop* --- ## [3.1.1](googleapis/nodejs-dialogflow-cx@v3.1.0...v3.1.1) (2022-09-14) ### Bug Fixes * Allow passing gax instance to client constructor ([#310](googleapis/nodejs-dialogflow-cx#310)) ([5eb33cd](googleapis/nodejs-dialogflow-cx@5eb33cd)) * Better support for fallback mode ([#305](googleapis/nodejs-dialogflow-cx#305)) ([f63bcf2](googleapis/nodejs-dialogflow-cx@f63bcf2)) * Change import long to require ([#306](googleapis/nodejs-dialogflow-cx#306)) ([343bc0e](googleapis/nodejs-dialogflow-cx@343bc0e)) * **deps:** Update dependency uuid to v9 ([#311](googleapis/nodejs-dialogflow-cx#311)) ([f7ba638](googleapis/nodejs-dialogflow-cx@f7ba638)) * Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-dialogflow-cx/issues/1553)) ([#309](googleapis/nodejs-dialogflow-cx#309)) ([844c8f7](googleapis/nodejs-dialogflow-cx@844c8f7)) * Preserve default values in x-goog-request-params header ([#312](googleapis/nodejs-dialogflow-cx#312)) ([239d018](googleapis/nodejs-dialogflow-cx@239d018)) * Remove pip install statements ([#1546](https://github.com/googleapis/nodejs-dialogflow-cx/issues/1546)) ([#308](googleapis/nodejs-dialogflow-cx#308)) ([7363dfe](googleapis/nodejs-dialogflow-cx@7363dfe)) * use google-gax v3.3.0 ([844c8f7](googleapis/nodejs-dialogflow-cx@844c8f7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl
pushed a commit
that referenced
this pull request
Nov 17, 2022
This was referenced Nov 17, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 18, 2022
sofisl
pushed a commit
that referenced
this pull request
Nov 18, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [5.0.2](https://www.github.com/googleapis/nodejs-security-center/compare/v5.0.1...v5.0.2) (2020-07-27) ### Bug Fixes * add resource config to v1beta1 ([#307](https://www.github.com/googleapis/nodejs-security-center/issues/307)) ([5d99acf](https://www.github.com/googleapis/nodejs-security-center/commit/5d99acf9dea7a6e2d384ee709678365c769f3d6e)) * correct securitycenter grpc_service_configs, add Node 8 tests ([#302](https://www.github.com/googleapis/nodejs-security-center/issues/302)) ([4e4ec5b](https://www.github.com/googleapis/nodejs-security-center/commit/4e4ec5bbd9623dc952781e80da226320db3906af)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please).
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Nov 30, 2022
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Jan 17, 2023
sofisl
pushed a commit
that referenced
this pull request
Jan 24, 2023
sofisl
pushed a commit
that referenced
this pull request
Jan 25, 2023
sofisl
pushed a commit
that referenced
this pull request
Jan 26, 2023
…ta1 explanation.proto (#307) * feat: add Examples to Explanation related messages in aiplatform v1beta1 explanation.proto
sofisl
pushed a commit
that referenced
this pull request
Jan 26, 2023
🤖 I have created a release *beep* *boop* --- ## [2.0.0](googleapis/nodejs-ai-platform@v1.19.0...v2.0.0) (2022-06-23) ### ⚠ BREAKING CHANGES * update library to use Node 12 (#304) ### Features * add ConvexAutomatedStoppingSpec to StudySpec in aiplatform v1beta1 study.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add display_name and metadata to ModelEvaluation in aiplatform model_evaluation.proto ([#297](googleapis/nodejs-ai-platform#297)) ([1e6dcb6](googleapis/nodejs-ai-platform@1e6dcb6)) * add Examples to Explanation related messages in aiplatform v1beta1 explanation.proto ([#307](googleapis/nodejs-ai-platform#307)) ([c69ac2b](googleapis/nodejs-ai-platform@c69ac2b)) * add IAM policy to aiplatform_v1beta1.yaml ([#308](googleapis/nodejs-ai-platform#308)) ([6557767](googleapis/nodejs-ai-platform@6557767)) * add JOB_STATE_UPDATING to JobState in aiplatform v1beta1 job_state.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add LatestMonitoringPipelineMetadata to ModelDeploymentMonitoringJob in aiplatform v1beta1 model_deployment_monitoring_job.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add ListModelVersion, DeleteModelVersion, and MergeVersionAliases rpcs to aiplatform v1beta1 model_service.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add MfsMount in aiplatform v1beta1 machine_resources.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add model_id and parent_model to TrainingPipeline in aiplatform v1beta1 training_pipeline.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add model_version_id to DeployedModel in aiplatform v1beta1 endpoint.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add model_version_id to PredictResponse in aiplatform v1beta1 prediction_service.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add model_version_id to UploadModelRequest and UploadModelResponse in aiplatform v1beta1 model_service.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add nfs_mounts to WorkPoolSpec in aiplatform v1beta1 custom_job.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add PredictRequestResponseLoggingConfig to aiplatform v1beta1 endpoint.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add reserved_ip_ranges to CustomJobSpec in aiplatform v1 custom_job.proto ([#286](googleapis/nodejs-ai-platform#286)) ([863748a](googleapis/nodejs-ai-platform@863748a)) * add reserved_ip_ranges to CustomJobSpec in aiplatform v1beta1 custom_job.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * add version_id to Model in aiplatform v1beta1 model.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * rename Similarity to Examples, and similarity to examples in ExplanationParameters in aiplatform v1beta1 explanation.proto ([863748a](googleapis/nodejs-ai-platform@863748a)) * **samples:** add create-featurestore samples ([#317](googleapis/nodejs-ai-platform#317)) ([5876d81](googleapis/nodejs-ai-platform@5876d81)) ### Bug Fixes * added retries to flaky test ([#299](googleapis/nodejs-ai-platform#299)) ([ffc9a3f](googleapis/nodejs-ai-platform@ffc9a3f)) ### Build System * update library to use Node 12 ([#304](googleapis/nodejs-ai-platform#304)) ([0679cda](googleapis/nodejs-ai-platform@0679cda)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
4 tasks
sofisl
pushed a commit
that referenced
this pull request
Sep 14, 2023
4 tasks
This was referenced May 13, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems the regression test for pubsub ack is not working. This is because
message.dataisundefined(maybe upstream change?). This made the test pass by just checking if it exists first, and if it doesn't, don't bother trying to include it.