allow setting gRPC metadata #1546

stephenplusplus · 2016-08-30T19:36:23Z

To Dos

Unit tests

@murgatroid99 -- could you take a look and let me know if this is the correct way to set metadata? Thanks!

packages/common/src/grpc-service.js

      grpc.credentials.createSsl(),
      grpc.credentials.createFromGoogleCredential(authClient)
+    ];
+
+    callCredentialObjects = callCredentialObjects.concat(self.callCredentials);


packages/common/src/grpc-service.js

+
+    for (var prop in metadata) {
+      grpcMetadata.add(prop, metadata[prop]);
+    }


murgatroid99 · 2016-08-30T20:51:25Z

This is an unexpected use of call credentials, but it should work.

Another option would be to add the metadata directly to the per call metadata when making a call, by doing something like this wherever you make grpc calls:

for (prop in metadata) {
  perCallMetadata.add(prop, metadata[prop]);
}
service.callMethod(argument, perCallMetadata, callback);

coveralls · 2016-08-30T21:58:48Z

Changes Unknown when pulling 975f506 on stephenplusplus:spp--1542 into * on GoogleCloudPlatform:master*.

packages/common/src/grpc-service.js


+  var metadata = null;


packages/common/src/grpc-service.js

@@ -158,6 +159,18 @@ function GrpcService(config, options) {
    this.grpcCredentials = grpc.credentials.createInsecure();
  }

+  this.grpcMetadata = null;


coveralls · 2016-09-02T07:38:25Z

Coverage remained the same at 100.0% when pulling 9cf0c10 on stephenplusplus:spp--1542 into bf9929e on GoogleCloudPlatform:master.

coveralls · 2016-09-02T09:47:19Z

Coverage remained the same at 100.0% when pulling 9cf0c10 on stephenplusplus:spp--1542 into bf9929e on GoogleCloudPlatform:master.

packages/common/test/grpc-service.js

@@ -241,11 +241,17 @@ describe('GrpcService', function() {
    });

    it('should default grpcMetadata to null', function() {


🤖 I have created a release *beep* *boop* --- ## [3.0.2](googleapis/nodejs-dns@v3.0.1...v3.0.2) (2022-08-23) ### Bug Fixes * remove pip install statements ([#1546](https://github.com/googleapis/nodejs-dns/issues/1546)) ([#534](googleapis/nodejs-dns#534)) ([b3a77f0](googleapis/nodejs-dns@b3a77f0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

stephenplusplus added the core label Aug 30, 2016

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 30, 2016

stephenplusplus reviewed Aug 30, 2016
View reviewed changes

packages/common/src/grpc-service.js

grpc.credentials.createSsl(),

grpc.credentials.createFromGoogleCredential(authClient)

];

callCredentialObjects = callCredentialObjects.concat(self.callCredentials);

This comment was marked as spam.

Sign in to view

stephenplusplus added the don't merge label Aug 30, 2016

murgatroid99 reviewed Aug 30, 2016
View reviewed changes

packages/common/src/grpc-service.js

for (var prop in metadata) {

grpcMetadata.add(prop, metadata[prop]);

}

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

stephenplusplus reviewed Aug 31, 2016
View reviewed changes

packages/common/src/grpc-service.js

var metadata = null;

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

stephenplusplus force-pushed the spp--1542 branch from 5be4355 to e0ac517 Compare September 1, 2016 20:37

stephenplusplus removed the don't merge label Sep 1, 2016

stephenplusplus assigned callmehiphop Sep 1, 2016

callmehiphop reviewed Sep 1, 2016
View reviewed changes

stephenplusplus mentioned this pull request Sep 2, 2016

Datastore: add google-cloud-resource-prefix header #1558

Merged

stephenplusplus added 5 commits September 1, 2016 22:07

allow setting gRPC metadata

6c112bf

set metadata per call

cbd23f3

refactor and test

eff7266

always default to empty metadata

6cc716b

lint issue

9cf0c10

stephenplusplus force-pushed the spp--1542 branch from 71470f9 to 9cf0c10 Compare September 2, 2016 02:09

callmehiphop reviewed Sep 2, 2016
View reviewed changes

packages/common/test/grpc-service.js

@@ -241,11 +241,17 @@ describe('GrpcService', function() {

});

it('should default grpcMetadata to null', function() {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Update grpc-service.js

c68b260

callmehiphop merged commit e413ed4 into googleapis:master Sep 2, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow setting gRPC metadata #1546

allow setting gRPC metadata #1546

stephenplusplus commented Aug 30, 2016 •

edited

Loading

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

murgatroid99 commented Aug 30, 2016

coveralls commented Aug 30, 2016 •

edited

Loading

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Sep 2, 2016 •

edited

Loading

coveralls commented Sep 2, 2016 •

edited

Loading

This comment was marked as spam.

This comment was marked as spam.

		@@ -241,11 +241,17 @@ describe('GrpcService', function() {
		});

		it('should default grpcMetadata to null', function() {

allow setting gRPC metadata #1546

allow setting gRPC metadata #1546

Conversation

stephenplusplus commented Aug 30, 2016 • edited Loading

To Dos

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

murgatroid99 commented Aug 30, 2016

coveralls commented Aug 30, 2016 • edited Loading

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Sep 2, 2016 • edited Loading

coveralls commented Sep 2, 2016 • edited Loading

This comment was marked as spam.

This comment was marked as spam.

stephenplusplus commented Aug 30, 2016 •

edited

Loading

coveralls commented Aug 30, 2016 •

edited

Loading

coveralls commented Sep 2, 2016 •

edited

Loading

coveralls commented Sep 2, 2016 •

edited

Loading