fix(storage): fix routing header for writes #8159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes several integration tests that were broken since GCS started enforcing new formatting. Only writes are affected; for other calls, the GAPIC handles the routing annotation. Fixes googleapis#8142 Fixes googleapis#8143 Fixes googleapis#8144 Fixes googleapis#8145 Fixes googleapis#8149
product-auto-label
bot
added
size: xs
BrennaEpp
approved these changes
Jun 21, 2023
tritone
added a commit
to tritone/google-cloud-go
that referenced
this pull request
Jun 22, 2023
This was causing some of the failures that I thought I had addressed in googleapis#8159. Fix by specifying the bucket name using CreateBucketRequest.BucketID rather than CreateBucketRequest.Bucket.Name. Also cleans up some messy logic around specifying bucket names for integration tests that I ended up looking at. Fixes googleapis#8162
tritone
added a commit
that referenced
this pull request
Jun 22, 2023
This was causing some of the failures that I thought I had addressed in #8159. Fix by specifying the bucket name using CreateBucketRequest.BucketID rather than CreateBucketRequest.Bucket.Name. Also cleans up some messy logic around specifying bucket names for integration tests that I ended up looking at. Fixes #8162
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes several integration tests that were broken since GCS started enforcing new formatting. Only writes are affected; for other calls, the GAPIC handles the routing annotation.
Fixes #8142
Fixes #8143
Fixes #8144
Fixes #8145
Fixes #8149