Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: many tests failed #8162

Closed
flaky-bot bot opened this issue Jun 21, 2023 · 2 comments · Fixed by #8165
Closed

storage: many tests failed #8162

flaky-bot bot opened this issue Jun 21, 2023 · 2 comments · Fixed by #8165
Assignees
@tritone
Labels
api: storage Issues related to the Cloud Storage API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Jun 21, 2023

Many tests failed at the same time in this package.

  • I will close this issue when there are no more failures in this package and
    there is at least one pass.
  • No new issues will be filed for this package until this issue is closed.
  • If there are already issues for individual test cases, I will close them when
    the corresponding test passes. You can close them earlier, if you prefer, and
    I won't reopen them while this issue is still open.

Here are the tests that failed:

commit: 42a59f5
buildURL: Build Status, Sponge
status: failed
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 21, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jun 21, 2023
@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 21, 2023

20 tests failed in this package for commit 9426a5a (Build Status, Sponge).

commit: 9426a5a
buildURL: Build Status, Sponge
status: failed

@tritone
Copy link
Contributor

tritone commented Jun 22, 2023

I fixed an issue related to this for uploads but there still seems to be one for bucket creation. Investigating.

tritone added a commit to tritone/google-cloud-go that referenced this issue Jun 22, 2023
@tritone
fix(storage): fix CreateBucket logic for gRPC
6aa1946 
This was causing some of the failures that I thought I had
addressed in googleapis#8159. Fix by specifying the bucket name using
CreateBucketRequest.BucketID rather than
CreateBucketRequest.Bucket.Name.

Also cleans up some messy logic around specifying bucket names
for integration tests that I ended up looking at.

Fixes googleapis#8162
@tritone tritone mentioned this issue Jun 22, 2023
Merged
tritone added a commit that referenced this issue Jun 22, 2023
@tritone
fix(storage): fix CreateBucket logic for gRPC (#8165)
8424e7e 
This was causing some of the failures that I thought I had
addressed in #8159. Fix by specifying the bucket name using
CreateBucketRequest.BucketID rather than
CreateBucketRequest.Bucket.Name.

Also cleans up some messy logic around specifying bucket names
for integration tests that I ended up looking at.

Fixes #8162
@release-please release-please bot mentioned this issue Jun 22, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tritone tritone

Labels
api: storage Issues related to the Cloud Storage API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(storage): fix CreateBucket logic for gRPC tritone/google-cloud-go
1 participant
@tritone