Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: TestIntegration_UpdateCORS failed #8143

Closed
flaky-bot bot opened this issue Jun 17, 2023 · 0 comments · Fixed by #8159
Closed

storage: TestIntegration_UpdateCORS failed #8143

flaky-bot bot opened this issue Jun 17, 2023 · 0 comments · Fixed by #8159
Assignees
@tritone
Labels
api: storage Issues related to the Cloud Storage API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Jun 17, 2023

Note: #7465 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.

commit: 005d2df
buildURL: Build Status, Sponge
status: failed

Test output
    integration_test.go:5105: integration_test.go:3467: bucket create: rpc error: code = InvalidArgument desc = Invalid bucket name 'golang-grpc-test-go-integration-test-1686963639194348249-49'. Bucket names must take the form 'projects/{project-number}/buckets/{bucket-id}'. project_number may be a '_'.
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 17, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jun 17, 2023
@flaky-bot flaky-bot bot mentioned this issue Jun 17, 2023
Closed
tritone added a commit to tritone/google-cloud-go that referenced this issue Jun 21, 2023
@tritone
fix(storage): fix routing header for writes
0ba90e4 
This fixes several integration tests that were broken since
GCS started enforcing new formatting. Only writes are affected;
for other calls, the GAPIC handles the routing annotation.

Fixes googleapis#8142
Fixes googleapis#8143
Fixes googleapis#8144
Fixes googleapis#8145
Fixes googleapis#8149
@tritone tritone mentioned this issue Jun 21, 2023
Merged
tritone added a commit that referenced this issue Jun 21, 2023
@tritone
fix(storage): fix routing header for writes (#8159)
42a59f5 
This fixes several integration tests that were broken since
GCS started enforcing new formatting. Only writes are affected;
for other calls, the GAPIC handles the routing annotation.

Fixes #8142
Fixes #8143
Fixes #8144
Fixes #8145
Fixes #8149
@release-please release-please bot mentioned this issue Jun 21, 2023
Merged
@flaky-bot flaky-bot bot mentioned this issue Jun 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tritone tritone

Labels
api: storage Issues related to the Cloud Storage API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(storage): fix routing header for writes tritone/google-cloud-go
1 participant
@tritone