Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spanner: only retry certain types of internal errors. #2460

Merged
merged 2 commits into from
Jun 19, 2020
Merged

spanner: only retry certain types of internal errors. #2460

merged 2 commits into from
Jun 19, 2020

Conversation

hengfengli
Copy link
Contributor

@hengfengli hengfengli added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. api: spanner Issues related to the Spanner API. labels Jun 16, 2020
@hengfengli hengfengli requested a review from olavloite June 16, 2020 05:28
@hengfengli hengfengli self-assigned this Jun 16, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 16, 2020
olavloite
olavloite requested changes Jun 16, 2020
View reviewed changes
spanner/retry.go Show resolved Hide resolved
olavloite
olavloite approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@olavloite olavloite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but please have a quick look at my last comment to see if you want to apply some of that before merging.

spanner/retry.go Show resolved Hide resolved
spanner/retry.go Show resolved Hide resolved
@hengfengli hengfengli requested a review from skuruppu as a code owner June 19, 2020 12:03
@hengfengli hengfengli force-pushed the fix-internal-error-retry branch from c9872e4 to 5fea553 Compare June 19, 2020 12:04
@hengfengli hengfengli merged commit 9f9e9d2 into googleapis:master Jun 19, 2020
@hengfengli hengfengli deleted the fix-internal-error-retry branch June 19, 2020 12:19
@apstndb apstndb mentioned this pull request Aug 24, 2020
Open
@vishwarajanand vishwarajanand mentioned this pull request Mar 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olavloite olavloite olavloite approved these changes

@skuruppu skuruppu Awaiting requested review from skuruppu

Assignees

@hengfengli hengfengli

Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spanner: infinite retrying due to invalid utf-8 query
3 participants
@hengfengli @olavloite @googlebot