fix(Spanner): add retry for RST_STREAM #5938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajupazhamayil
approved these changes
Mar 10, 2023
bshaffer
reviewed
Mar 10, 2023
vishwarajanand
added
the
do not merge
vishwarajanand
commented
Mar 24, 2023
vishwarajanand
removed
the
do not merge
bshaffer
reviewed
Apr 5, 2023
bshaffer
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spanner is supposed to retry on RST_STREAM errors. We retry on all INTERNAL errors, code pointer ref so only
runTransactionneed to be additionally covered.This will bring PHP spanner in parity with other language's retry on error codes, ref: googleapis/java-spanner#2111, googleapis/google-cloud-go#2460 and also potentially fix #5473.
Changes
Add default retry delay for
RST_STREAMerrros.Tests
Added a new UT for validating that the retry happens for RST_STREAM errors.
ref: b/272395017