spanner: infinite retrying due to invalid utf-8 query

[hengfengli]

Client

spanner/v1.6.0

Code

package main
 
import (
	"context"
	"encoding/base64"
	"log"
 
	"cloud.google.com/go/spanner"
)
 
const db = "projects/:project/instances/:instance/databases/:database"
 
func main() {
	ctx := context.Background()
	client, _ := spanner.NewClient(ctx, db)
	b, _ := base64.StdEncoding.DecodeString("hoge")
	log.Println("query")
	iter := client.Single().Query(ctx, spanner.Statement{
		SQL:    "SELECT * FROM Singers WHERE FirstName = @singerName",
		Params: map[string]interface{}{"singerName": string(b)},
	})
	log.Println("next")
	if _, err := iter.Next(); err != nil {
		log.Fatalf("%+v", err)
	}
	log.Println("done")
}

Expected behavior

Get an internal error: rpc error: code = Internal desc = grpc: error while marshaling: string field contains invalid UTF-8

Actual behavior

It causes an Infinite retrying behaviour.

[hengfengli]

The current plan is to keep consistent with Java client lib to only retry one of three specific types of internal errors:

https://github.com/googleapis/java-spanner/blob/f89da6a1f4f8a86c136a23dfd2f5b073dd65407a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerExceptionFactory.java#L257-L269