Market: fix rest responses #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiezzel
previously approved these changes
Nov 5, 2020
tworec
commented
Nov 16, 2020
| @@ -153,7 +153,7 @@ async fn approve_agreement( | |||
| .approve_agreement(id, &agreement_id, timeout) | |||
| .await | |||
| .log_err() | |||
| .map(|_| HttpResponse::NoContent().finish()) | |||
| .map(|status| HttpResponse::Ok().json(status.to_string())) | |||
There was a problem hiding this comment.
should be 410 Gone as suggested by @prekucki in case of Cancelled agreement
There was a problem hiding this comment.
Addressed here golemfactory/ya-client#70
tworec
force-pushed
the
market/fix-rest-responses
branch
from
a3e228f to
6b18463
Compare
…et/fix-rest-responses
…ket/fix-rest-responses
…ket/fix-rest-responses
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It breaks compatibility of Market API, so not to be merged before
Alpha.3.fixes #450 resolves golemfactory/golem-internal#204
depends on: golemfactory/ya-client#59
Contains changes from #850 and #869