AgreementEvents with common fields - compatibility with updated ya-client #869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tworec
reviewed
Dec 14, 2020
tworec
previously approved these changes
Dec 14, 2020
tworec
force-pushed
the
market/agreement-events-extract-common-fields
branch
from
715f5e3 to
2af6ab5
Compare
…b.com:golemfactory/yagna into market/agreement-events-extract-common-fields
tworec
force-pushed
the
market/agreement-events-extract-common-fields
branch
from
dce5a97 to
f2cda7b
Compare
tworec
force-pushed
the
market/agreement-events-extract-common-fields
branch
2 times, most recently
from
b7111f0 to
a17add8
Compare
* reworked transition error * more code reusage * fixed HTTP error Codes
tworec
force-pushed
the
market/agreement-events-extract-common-fields
branch
from
a17add8 to
fa24515
Compare
tworec
approved these changes
Dec 21, 2020
| match terminator { | ||
| OwnerType::Provider => counter!("market.agreements.provider.terminated", 1), | ||
| OwnerType::Requestor => counter!("market.agreements.requestor.terminated", 1), | ||
| }; | ||
|
|
||
| terminate_reason_metric(&msg.reason, owner_type); | ||
| inc_terminate_metrics(&msg.reason, owner_type); |
There was a problem hiding this comment.
this now contains the above metrics, so we need to remove them :(
sorry, my fault
| let filename = captures.get(1).unwrap().as_str().to_string(); | ||
| let testname = captures.get(2).unwrap().as_str().to_string(); | ||
|
|
||
| format!("{}.{}", filename, testname) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves: #868
related to changes in ya-client: golemfactory/ya-client#79
Remember!!! Update referenced branch on ya-client to master, before merging this PR