Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Market: fix REST responses #59

Merged
merged 11 commits into from
Dec 11, 2020
Merged

Market: fix REST responses #59

merged 11 commits into from
Dec 11, 2020

Conversation

tworec
Copy link
Contributor

@tworec tworec commented Nov 4, 2020 •
edited
Loading

It breaks compatibility of Market API, so not to be merged before Alpha.3.

fixes #21
golemfactory/yagna#765 depends on this PR.

@tworec tworec changed the base branch from master to stranger80/market-api-events November 4, 2020 15:19
@tworec tworec changed the base branch from stranger80/market-api-events to master November 4, 2020 15:19
@tworec tworec changed the base branch from master to stranger80/market-api-events November 4, 2020 15:19
nieznanysprawiciel
nieznanysprawiciel reviewed Nov 4, 2020
View reviewed changes
Copy link
Contributor

@nieznanysprawiciel nieznanysprawiciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires change in ya-client, because it returns String either

@tworec
Copy link
Contributor Author

tworec commented Nov 4, 2020

pls check now

@tworec tworec force-pushed the stranger80/market-api-events branch from 5738047 to 27bdc52 Compare November 5, 2020 20:25
Base automatically changed from stranger80/market-api-events to master November 9, 2020 13:35
@tworec tworec dismissed nieznanysprawiciel’s stale review November 9, 2020 13:35

The base branch was changed.

@tworec tworec mentioned this pull request Nov 10, 2020
Merged
tworec added a commit to golemfactory/yagna that referenced this pull request Nov 10, 2020
@tworec
bump ya-client to align with golemfactory/ya-client#59
8aa12fe
@tworec tworec mentioned this pull request Dec 9, 2020
Closed
2 tasks
@tworec tworec mentioned this pull request Dec 10, 2020
Merged
jiivan
jiivan approved these changes Dec 11, 2020
View reviewed changes
Copy link

@jiivan jiivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but IMO it should be marked more visibly as not ready for merge (either draft type or WIP in title?)

@tworec tworec changed the base branch from master to event-api/master December 11, 2020 15:10
@tworec
Copy link
Contributor Author

tworec commented Dec 11, 2020

lgtm, but IMO it should be marked more visibly as not ready for merge (either draft type or WIP in title?)

I will merge it to the event-api/master not to break master

@tworec tworec merged commit 7681cdc into event-api/master Dec 11, 2020
@tworec tworec deleted the market/fix-rest-responses branch December 11, 2020 16:07
@tworec tworec mentioned this pull request Dec 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiivan jiivan jiivan approved these changes

@nieznanysprawiciel nieznanysprawiciel nieznanysprawiciel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Market unsubscribe result type
3 participants
@tworec @jiivan @nieznanysprawiciel