Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/telemetry/internal/counter: TestNewFile persistently failing on GOOS=solaris GOARCH=amd64 using Go 1.20 and Go tip #60970

Closed
dmitshur opened this issue Jun 23, 2023 · 5 comments
Closed

x/telemetry/internal/counter: TestNewFile persistently failing on GOOS=solaris GOARCH=amd64 using Go 1.20 and Go tip #60970

dmitshur opened this issue Jun 23, 2023 · 5 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Solaris telemetry x/telemetry issues
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jun 23, 2023 •
edited by bcmills
Loading 

#!watchflakes
post <- pkg == "golang.org/x/telemetry/internal/counter" && test == "TestNewFile" && goos == "solaris" && `days = 7`

From https://build.golang.org/log/466ee94eb52ce64476d1b75d9a3fc1c26f4a9094:

--- FAIL: TestNewFile (0.01s)
    counter_test.go:164: GOOS solaris GARCH amd64
    counter_test.go:220: 2: days = 7, want 7 < days <= 14
    counter_test.go:220: 9: days = 7, want 7 < days <= 14
    counter_test.go:220: 11: days = 7, want 7 < days <= 14
2023/06/23 14:12:34 closing /tmp/workdir-host-solaris-oracle-amd64-oraclerel/tmp/TestRotate1832009220/001/local/counter.test-go1.20.5-solaris-amd64-2023-06-23.v1.count
FAIL
FAIL	golang.org/x/telemetry/internal/counter	0.159s

This happens on Go 1.20 release branch at Go tip. Very similar to #60966.

CC @golang/solaris, @rorth.
@dmitshur dmitshur added OS-Solaris NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues labels Jun 23, 2023
@dmitshur dmitshur added this to the Unreleased milestone Jun 23, 2023
@dmitshur dmitshur mentioned this issue Jun 23, 2023
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/505580 mentions this issue: internal/counter: skip tests on solaris, android, and GOARCH=386

gopherbot pushed a commit to golang/telemetry that referenced this issue Jun 23, 2023
@hyangah
internal/counter: skip tests on solaris, android, and GOARCH=386
de303cd 
Updates golang/go#60615
Updates golang/go#60692
Updates golang/go#60965
Updates golang/go#60967
Updates golang/go#60968
Updates golang/go#60970
Updates golang/go#60971

Change-Id: Ifb0320c279e91185ab04c3efa6bf20f2c141dbe1
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/505580
Reviewed-by: Jamal Carvalho <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
@bcmills bcmills mentioned this issue Jun 23, 2023
Closed
@gopherbot
Copy link
Contributor

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/telemetry/internal/counter" && test == "TestNewFile" && goos == "solaris" && `days = 7`
2023-06-23 12:10 solaris-amd64-oraclerel telemetry@09c2e0cd go@48dbb622 x/telemetry/internal/counter.TestNewFile (log) 
--- FAIL: TestNewFile (0.01s)
    counter_test.go:164: GOOS solaris GARCH amd64
    counter_test.go:220: 0: days = 7, want 7 < days <= 14
    counter_test.go:220: 3: days = 7, want 7 < days <= 14
    counter_test.go:220: 9: days = 7, want 7 < days <= 14
2023/06/23 19:22:52 closing /tmp/workdir-host-solaris-oracle-amd64-oraclerel/tmp/TestRotate3757461153/001/local/counter.test-devel-solaris-amd64-2023-06-23.v1.count
2023-06-23 12:10 solaris-amd64-oraclerel telemetry@09c2e0cd go@3adcce5a x/telemetry/internal/counter.TestNewFile (log) 
--- FAIL: TestNewFile (0.01s)
    counter_test.go:164: GOOS solaris GARCH amd64
    counter_test.go:220: 0: days = 7, want 7 < days <= 14
    counter_test.go:220: 15: days = 7, want 7 < days <= 14
2023/06/23 18:39:09 closing /tmp/workdir-host-solaris-oracle-amd64-oraclerel/tmp/TestRotate3987462832/001/local/counter.test-devel-solaris-amd64-2023-06-23.v1.count
2023-06-23 12:10 solaris-amd64-oraclerel telemetry@09c2e0cd go@6dce882b x/telemetry/internal/counter.TestNewFile (log) 
--- FAIL: TestNewFile (0.01s)
    counter_test.go:164: GOOS solaris GARCH amd64
    counter_test.go:220: 6: days = 7, want 7 < days <= 14
    counter_test.go:220: 12: days = 7, want 7 < days <= 14
    counter_test.go:220: 16: days = 7, want 7 < days <= 14
2023/06/23 17:00:45 closing /tmp/workdir-host-solaris-oracle-amd64-oraclerel/tmp/TestRotate4122084287/001/local/counter.test-devel-solaris-amd64-2023-06-23.v1.count

— watchflakes

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/508499 mentions this issue: internal/counter: add test logging to debug TestNewFile flakiness

gopherbot pushed a commit to golang/telemetry that referenced this issue Jul 8, 2023
@hyangah
internal/counter: add test logging to debug TestNewFile flakiness
cbe576d 
TestNewFile is flakay and consistently failing on linux-amd64-wsl.
The test checks if the end timestamp in the counter file's metadata
is within a reasonable range by computing the time since a test
reference timestamp ('now').

Log all involved timestamps for investigation.

WSL https://build.golang.org/log/fd86b72f06c8291187d0a30c41d24ddb9e959207
RISCV64 https://build.golang.org/log/3392c1e69a53dd6adf359de10923a771ef77b488
Solaris https://build.golang.org/log/466ee94eb52ce64476d1b75d9a3fc1c26f4a9094

For golang/go#60970
For golang/go#60966

Change-Id: I0a9060cee524761245c7f470938f63c1b6717d1f
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/508499
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Peter Weinberger <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/508501 mentions this issue: internal/counter: fix TestNewFile test

gopherbot pushed a commit to golang/telemetry that referenced this issue Jul 10, 2023
@hyangah
internal/counter: fix TestNewFile test
9ec2990 
The test checks whether a newly created counter file has
the TimeEnd metadata value within expected range, by computing
the time difference between the TimeEnd value and a test reference
time computed at the beginning of the test.
Unfortunately, the reference timestamp calculation used a different
time zone than what's used in computing TimeEnd, and caused the
test failure on some builders with some probabilities depending on
builders' time zones.

Here is the log from the test failure that shows this issue.


--- FAIL: TestNewFile (0.00s)
    counter_test.go:177: GOOS linux GOARCH amd64
    counter_test.go:233: now: 2023-07-08 00:00:00 +0000 UTC file: counter.test-go1.19.10-linux-amd64-2023-07-08.v1.count TimeBegin: 2023-07-08 00:00:00 +0800 CST TimeEnd: 2023-07-16 00:00:00 +0800 CST
    counter_test.go:234: 0: days = 7, want 7 < days <= 14
    counter_test.go:233: now: 2023-07-08 00:00:00 +0000 UTC file: counter.test-go1.19.10-linux-amd64-2023-07-08.v1.count TimeBegin: 2023-07-08 00:00:00 +0800 CST TimeEnd: 2023-07-16 00:00:00 +0800 CST
    counter_test.go:234: 13: days = 7, want 7 < days <= 14
    counter_test.go:233: now: 2023-07-08 00:00:00 +0000 UTC file: counter.test-go1.19.10-linux-amd64-2023-07-08.v1.count TimeBegin: 2023-07-08 00:00:00 +0800 CST TimeEnd: 2023-07-16 00:00:00 +0800 CST
    counter_test.go:234: 15: days = 7, want 7 < days <= 14

For golang/go#60970
Fixes golang/go#60966

Change-Id: I52936f5fe12c13f7ccf3c052cbbb9b403fcad332
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/508501
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Peter Weinberger <[email protected]>
Run-TryBot: Heschi Kreinick <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
@findleyr
Copy link
Member

I believe this is done, or obsolete with other work to get telemetry passing on the LUCI builders.

Pinkle-pash added a commit to Pinkle-pash/telemetry that referenced this issue Dec 4, 2024
@Pinkle-pash
internal/counter: skip tests on solaris, android, and GOARCH=386
56984f0 
Updates golang/go#60615
Updates golang/go#60692
Updates golang/go#60965
Updates golang/go#60967
Updates golang/go#60968
Updates golang/go#60970
Updates golang/go#60971

Change-Id: Ifb0320c279e91185ab04c3efa6bf20f2c141dbe1
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/505580
Reviewed-by: Jamal Carvalho <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
Pinkle-pash added a commit to Pinkle-pash/telemetry that referenced this issue Dec 4, 2024
@Pinkle-pash
internal/counter: add test logging to debug TestNewFile flakiness
c177e5f 
TestNewFile is flakay and consistently failing on linux-amd64-wsl.
The test checks if the end timestamp in the counter file's metadata
is within a reasonable range by computing the time since a test
reference timestamp ('now').

Log all involved timestamps for investigation.

WSL https://build.golang.org/log/fd86b72f06c8291187d0a30c41d24ddb9e959207
RISCV64 https://build.golang.org/log/3392c1e69a53dd6adf359de10923a771ef77b488
Solaris https://build.golang.org/log/466ee94eb52ce64476d1b75d9a3fc1c26f4a9094

For golang/go#60970
For golang/go#60966

Change-Id: I0a9060cee524761245c7f470938f63c1b6717d1f
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/508499
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Peter Weinberger <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
Pinkle-pash added a commit to Pinkle-pash/telemetry that referenced this issue Dec 4, 2024
@Pinkle-pash
internal/counter: fix TestNewFile test
d388690 
The test checks whether a newly created counter file has
the TimeEnd metadata value within expected range, by computing
the time difference between the TimeEnd value and a test reference
time computed at the beginning of the test.
Unfortunately, the reference timestamp calculation used a different
time zone than what's used in computing TimeEnd, and caused the
test failure on some builders with some probabilities depending on
builders' time zones.

Here is the log from the test failure that shows this issue.


--- FAIL: TestNewFile (0.00s)
    counter_test.go:177: GOOS linux GOARCH amd64
    counter_test.go:233: now: 2023-07-08 00:00:00 +0000 UTC file: counter.test-go1.19.10-linux-amd64-2023-07-08.v1.count TimeBegin: 2023-07-08 00:00:00 +0800 CST TimeEnd: 2023-07-16 00:00:00 +0800 CST
    counter_test.go:234: 0: days = 7, want 7 < days <= 14
    counter_test.go:233: now: 2023-07-08 00:00:00 +0000 UTC file: counter.test-go1.19.10-linux-amd64-2023-07-08.v1.count TimeBegin: 2023-07-08 00:00:00 +0800 CST TimeEnd: 2023-07-16 00:00:00 +0800 CST
    counter_test.go:234: 13: days = 7, want 7 < days <= 14
    counter_test.go:233: now: 2023-07-08 00:00:00 +0000 UTC file: counter.test-go1.19.10-linux-amd64-2023-07-08.v1.count TimeBegin: 2023-07-08 00:00:00 +0800 CST TimeEnd: 2023-07-16 00:00:00 +0800 CST
    counter_test.go:234: 15: days = 7, want 7 < days <= 14

For golang/go#60970
Fixes golang/go#60966

Change-Id: I52936f5fe12c13f7ccf3c052cbbb9b403fcad332
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/508501
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
Reviewed-by: Peter Weinberger <[email protected]>
Run-TryBot: Heschi Kreinick <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Solaris telemetry x/telemetry issues
Projects
Test Flakes
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @gopherbot @findleyr