Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/telemetry/internal/mmap: fails to build on GOOS=solaris GOARCH=amd64 on Go 1.19 release branch #60968

Closed
dmitshur opened this issue Jun 23, 2023 · 2 comments
Closed

x/telemetry/internal/mmap: fails to build on GOOS=solaris GOARCH=amd64 on Go 1.19 release branch #60968

dmitshur opened this issue Jun 23, 2023 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Solaris telemetry x/telemetry issues
Milestone
Unreleased

Comments

@dmitshur
Copy link
Contributor

dmitshur commented Jun 23, 2023 •
edited
Loading

From https://build.golang.org/log/e20b219bc7acca61048578e435da438c8e05d0e3:

# golang.org/x/telemetry/internal/mmap
internal/mmap/mmap_unix.go:31:23: undefined: syscall.Mmap
internal/mmap/mmap_unix.go:42:17: undefined: syscall.Munmap
note: module requires Go 1.20

Given go.mod says "1.20", maybe Go 1.19 shouldn't be attempted to be supported, and the builder just needs to require at least Go 1.20 branch.

CC @golang/solaris, @rorth.
@dmitshur dmitshur added OS-Solaris NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. telemetry x/telemetry issues labels Jun 23, 2023
@dmitshur dmitshur added this to the Unreleased milestone Jun 23, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/505580 mentions this issue: internal/counter: skip tests on solaris, android, and GOARCH=386

gopherbot pushed a commit to golang/telemetry that referenced this issue Jun 23, 2023
@hyangah
internal/counter: skip tests on solaris, android, and GOARCH=386
de303cd 
Updates golang/go#60615
Updates golang/go#60692
Updates golang/go#60965
Updates golang/go#60967
Updates golang/go#60968
Updates golang/go#60970
Updates golang/go#60971

Change-Id: Ifb0320c279e91185ab04c3efa6bf20f2c141dbe1
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/505580
Reviewed-by: Jamal Carvalho <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/505715 mentions this issue: internal/mmap: use syscall.Mmap on solaris only with go1.20+

@hyangah hyangah mentioned this issue Jun 23, 2023
Closed
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Jun 23, 2023
@golang golang locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Solaris telemetry x/telemetry issues
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@dmitshur @gopherbot