Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/telemetry: A test fails for GOARCH=386 #60615

Closed
pjweinb opened this issue Jun 5, 2023 · 3 comments
Closed

x/telemetry: A test fails for GOARCH=386 #60615

pjweinb opened this issue Jun 5, 2023 · 3 comments
Labels
arch-386 Issues solely affecting the 32-bit x86 architecture NeedsFix The path to resolution is known, but the work has not been done. telemetry x/telemetry issues
Milestone
Unreleased

Comments

@pjweinb
Copy link

pjweinb commented Jun 5, 2023 •
edited by dmitshur
Loading

This is place holder to note that one of the telemetry tests fails if runtime.GOARCH == "386".
@gopherbot gopherbot added this to the Unreleased milestone Jun 5, 2023
@jamalc jamalc added the telemetry x/telemetry issues label Jun 8, 2023
@prattmic prattmic added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jun 12, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/505580 mentions this issue: internal/counter: skip tests on solaris, android, and GOARCH=386

gopherbot pushed a commit to golang/telemetry that referenced this issue Jun 23, 2023
@hyangah
internal/counter: skip tests on solaris, android, and GOARCH=386
de303cd 
Updates golang/go#60615
Updates golang/go#60692
Updates golang/go#60965
Updates golang/go#60967
Updates golang/go#60968
Updates golang/go#60970
Updates golang/go#60971

Change-Id: Ifb0320c279e91185ab04c3efa6bf20f2c141dbe1
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/505580
Reviewed-by: Jamal Carvalho <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
@hyangah hyangah changed the title x/telemetry: A test fails for linux-386 x/telemetry: A test fails for 386 Jun 23, 2023
@hyangah hyangah changed the title x/telemetry: A test fails for 386 x/telemetry: A test fails for GOARCH=386 Jun 23, 2023
@hyangah
Copy link
Contributor

hyangah commented Jun 23, 2023

Changed the title - tests on windows/386 were also skipped in response to #60965

@hyangah hyangah added the arch-386 Issues solely affecting the 32-bit x86 architecture label Jun 23, 2023
@hyangah hyangah mentioned this issue Jun 23, 2023
Closed
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/561995 mentions this issue: counter: support 386 systems

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 11, 2024
Pinkle-pash added a commit to Pinkle-pash/telemetry that referenced this issue Dec 4, 2024
@Pinkle-pash
internal/counter: skip tests on solaris, android, and GOARCH=386
56984f0 
Updates golang/go#60615
Updates golang/go#60692
Updates golang/go#60965
Updates golang/go#60967
Updates golang/go#60968
Updates golang/go#60970
Updates golang/go#60971

Change-Id: Ifb0320c279e91185ab04c3efa6bf20f2c141dbe1
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/505580
Reviewed-by: Jamal Carvalho <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Run-TryBot: Hyang-Ah Hana Kim <[email protected]>
Pinkle-pash added a commit to Pinkle-pash/telemetry that referenced this issue Dec 4, 2024
@Pinkle-pash
counter: support 386 systems
ad65e74 
Modify the way mmap is invoked on Windows systems to support our
technique for extending the size of counter files.
The existing code was overelaborate and failed on 386.

Also, stop generating empty file names for uploading.

Fixes golang/go#65447
Fixes golang/go#60692
Fixes golang/go#60615

Change-Id: I8349d250fb516c188850557d3d099378248fb17b
Reviewed-on: https://go-review.googlesource.com/c/telemetry/+/561995
Run-TryBot: Peter Weinberger <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arch-386 Issues solely affecting the 32-bit x86 architecture NeedsFix The path to resolution is known, but the work has not been done. telemetry x/telemetry issues
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@prattmic @dmitshur @hyangah @pjweinb @gopherbot @jamalc