Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quota permissions testcase #19822

Merged

Conversation

YangJiao0817
Copy link
Member

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@YangJiao0817 YangJiao0817 added area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc... labels Jan 10, 2024
@YangJiao0817 YangJiao0817 requested a review from a team as a code owner January 10, 2024 06:14
@YangJiao0817 YangJiao0817 self-assigned this Jan 10, 2024
@YangJiao0817 YangJiao0817 enabled auto-merge (squash) January 10, 2024 06:14
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (891f678) 67.54% compared to head (c9708d0) 67.54%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #19822      +/-   ##
==========================================
- Coverage   67.54%   67.54%   -0.01%     
==========================================
  Files         991      991              
  Lines      109171   109171              
  Branches     2719     2719              
==========================================
- Hits        73744    73740       -4     
- Misses      31460    31463       +3     
- Partials     3967     3968       +1     
Flag Coverage Δ
unittests 67.54% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@YangJiao0817 YangJiao0817 force-pushed the add-quota-api-permission-testcase branch from 2c9c70c to 038d071 Compare January 11, 2024 06:32
@YangJiao0817 YangJiao0817 disabled auto-merge January 11, 2024 06:39
@YangJiao0817 YangJiao0817 force-pushed the add-quota-api-permission-testcase branch from 038d071 to c9708d0 Compare January 11, 2024 07:49
@YangJiao0817 YangJiao0817 merged commit 80930da into goharbor:main Jan 12, 2024
17 of 18 checks passed
Vad1mo pushed a commit that referenced this pull request Jan 26, 2024
* registryctl/api/registry/blob: fix dropped test error (#19721)

Signed-off-by: Lars Lehtonen <[email protected]>

* Remove robot account update quota permission (#19819)

Signed-off-by: Yang Jiao <[email protected]>
Co-authored-by: Yang Jiao <[email protected]>

* Cache image list with digest key (#19801)

fixes #19429

Signed-off-by: stonezdj <[email protected]>
Co-authored-by: stonezdj <[email protected]>

* Add quota permissions testcase (#19822)

Signed-off-by: Yang Jiao <[email protected]>
Co-authored-by: Yang Jiao <[email protected]>

* deprecate gosec in makefile (#19828)

remove the unused the part from makefile

Signed-off-by: wang yan <[email protected]>

* Add verification that robot account duration is not 0 (#19829)

Signed-off-by: Yang Jiao <[email protected]>

* fix artifact page bug (#19807)

* fix artifact page bug

* update testcase

* Upgrade to distribution (registry) v3 alpha

This includes all the benefits of the v3 distribution, but also all breaking changes.

Most notably, Image Manifest v2 Schema v1 support has been dropped, as well as the `oss` and `swift` storage drivers.

Currently, this still relies on v2's github.com/docker/distribution/registry/client/auth/challenge, because that code has been removed from the public API in v3.

Signed-off-by: Aaron Dewes <[email protected]>

---------

Signed-off-by: Lars Lehtonen <[email protected]>
Signed-off-by: Yang Jiao <[email protected]>
Signed-off-by: stonezdj <[email protected]>
Signed-off-by: wang yan <[email protected]>
Signed-off-by: Aaron Dewes <[email protected]>
Co-authored-by: Lars Lehtonen <[email protected]>
Co-authored-by: Yang Jiao <[email protected]>
Co-authored-by: Yang Jiao <[email protected]>
Co-authored-by: stonezdj(Daojun Zhang) <[email protected]>
Co-authored-by: stonezdj <[email protected]>
Co-authored-by: Wang Yan <[email protected]>
Co-authored-by: ShengqiWang <[email protected]>
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
Signed-off-by: Yang Jiao <[email protected]>
Co-authored-by: Yang Jiao <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test automation/nightly-testing release-note/infra Infra related changes e.g. release, test, ship etc...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants