-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache image list with digest key #19801
Merged
stonezdj
merged 2 commits into
goharbor:main
from
stonezdj:23dec27_proxy_cache_image_list_ref
Jan 11, 2024
Merged
Cache image list with digest key #19801
stonezdj
merged 2 commits into
goharbor:main
from
stonezdj:23dec27_proxy_cache_image_list_ref
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stonezdj
assigned wy65701436 and zyyw and unassigned Vad1mo, OrlinVasilev and AllForNothing
Jan 5, 2024
stonezdj
force-pushed
the
23dec27_proxy_cache_image_list_ref
branch
from
January 5, 2024 09:47
7b30040
to
18d2548
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #19801 +/- ##
===========================================
- Coverage 67.54% 45.34% -22.21%
===========================================
Files 991 244 -747
Lines 109165 13332 -95833
Branches 2719 2719
===========================================
- Hits 73737 6045 -67692
+ Misses 31460 6986 -24474
+ Partials 3968 301 -3667
Flags with carried forward coverage won't be shown. Click here to find out more. |
fixes goharbor#19429 Signed-off-by: stonezdj <[email protected]>
stonezdj
force-pushed
the
23dec27_proxy_cache_image_list_ref
branch
from
January 10, 2024 02:16
18d2548
to
dcec0cf
Compare
zyyw
approved these changes
Jan 11, 2024
wy65701436
approved these changes
Jan 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Vad1mo
pushed a commit
that referenced
this pull request
Jan 26, 2024
* registryctl/api/registry/blob: fix dropped test error (#19721) Signed-off-by: Lars Lehtonen <[email protected]> * Remove robot account update quota permission (#19819) Signed-off-by: Yang Jiao <[email protected]> Co-authored-by: Yang Jiao <[email protected]> * Cache image list with digest key (#19801) fixes #19429 Signed-off-by: stonezdj <[email protected]> Co-authored-by: stonezdj <[email protected]> * Add quota permissions testcase (#19822) Signed-off-by: Yang Jiao <[email protected]> Co-authored-by: Yang Jiao <[email protected]> * deprecate gosec in makefile (#19828) remove the unused the part from makefile Signed-off-by: wang yan <[email protected]> * Add verification that robot account duration is not 0 (#19829) Signed-off-by: Yang Jiao <[email protected]> * fix artifact page bug (#19807) * fix artifact page bug * update testcase * Upgrade to distribution (registry) v3 alpha This includes all the benefits of the v3 distribution, but also all breaking changes. Most notably, Image Manifest v2 Schema v1 support has been dropped, as well as the `oss` and `swift` storage drivers. Currently, this still relies on v2's github.com/docker/distribution/registry/client/auth/challenge, because that code has been removed from the public API in v3. Signed-off-by: Aaron Dewes <[email protected]> --------- Signed-off-by: Lars Lehtonen <[email protected]> Signed-off-by: Yang Jiao <[email protected]> Signed-off-by: stonezdj <[email protected]> Signed-off-by: wang yan <[email protected]> Signed-off-by: Aaron Dewes <[email protected]> Co-authored-by: Lars Lehtonen <[email protected]> Co-authored-by: Yang Jiao <[email protected]> Co-authored-by: Yang Jiao <[email protected]> Co-authored-by: stonezdj(Daojun Zhang) <[email protected]> Co-authored-by: stonezdj <[email protected]> Co-authored-by: Wang Yan <[email protected]> Co-authored-by: ShengqiWang <[email protected]>
altynbaev
pushed a commit
to altynbaev/harbor
that referenced
this pull request
Jan 29, 2024
fixes goharbor#19429 Signed-off-by: stonezdj <[email protected]> Co-authored-by: stonezdj <[email protected]> Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #19429
Thank you for contributing to Harbor!
Comprehensive Summary of your change
Issue being fixed
Fixes #(issue)
Please indicate you've done the following: