Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache image list with digest key #19801

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Jan 5, 2024

fixes #19429

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.

@stonezdj stonezdj requested a review from a team as a code owner January 5, 2024 09:46
@stonezdj stonezdj added the release-note/update Update or Fix label Jan 5, 2024
@stonezdj stonezdj force-pushed the 23dec27_proxy_cache_image_list_ref branch from 7b30040 to 18d2548 Compare January 5, 2024 09:47
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7268a3f) 67.54% compared to head (fffac6e) 45.34%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #19801       +/-   ##
===========================================
- Coverage   67.54%   45.34%   -22.21%     
===========================================
  Files         991      244      -747     
  Lines      109165    13332    -95833     
  Branches     2719     2719               
===========================================
- Hits        73737     6045    -67692     
+ Misses      31460     6986    -24474     
+ Partials     3968      301     -3667     
Flag Coverage Δ
unittests 45.34% <ø> (-22.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 751 files with indirect coverage changes

@stonezdj stonezdj force-pushed the 23dec27_proxy_cache_image_list_ref branch from 18d2548 to dcec0cf Compare January 10, 2024 02:16
@stonezdj stonezdj enabled auto-merge (squash) January 10, 2024 02:18
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@stonezdj stonezdj merged commit 891f678 into goharbor:main Jan 11, 2024
12 of 13 checks passed
Vad1mo pushed a commit that referenced this pull request Jan 26, 2024
* registryctl/api/registry/blob: fix dropped test error (#19721)

Signed-off-by: Lars Lehtonen <[email protected]>

* Remove robot account update quota permission (#19819)

Signed-off-by: Yang Jiao <[email protected]>
Co-authored-by: Yang Jiao <[email protected]>

* Cache image list with digest key (#19801)

fixes #19429

Signed-off-by: stonezdj <[email protected]>
Co-authored-by: stonezdj <[email protected]>

* Add quota permissions testcase (#19822)

Signed-off-by: Yang Jiao <[email protected]>
Co-authored-by: Yang Jiao <[email protected]>

* deprecate gosec in makefile (#19828)

remove the unused the part from makefile

Signed-off-by: wang yan <[email protected]>

* Add verification that robot account duration is not 0 (#19829)

Signed-off-by: Yang Jiao <[email protected]>

* fix artifact page bug (#19807)

* fix artifact page bug

* update testcase

* Upgrade to distribution (registry) v3 alpha

This includes all the benefits of the v3 distribution, but also all breaking changes.

Most notably, Image Manifest v2 Schema v1 support has been dropped, as well as the `oss` and `swift` storage drivers.

Currently, this still relies on v2's github.com/docker/distribution/registry/client/auth/challenge, because that code has been removed from the public API in v3.

Signed-off-by: Aaron Dewes <[email protected]>

---------

Signed-off-by: Lars Lehtonen <[email protected]>
Signed-off-by: Yang Jiao <[email protected]>
Signed-off-by: stonezdj <[email protected]>
Signed-off-by: wang yan <[email protected]>
Signed-off-by: Aaron Dewes <[email protected]>
Co-authored-by: Lars Lehtonen <[email protected]>
Co-authored-by: Yang Jiao <[email protected]>
Co-authored-by: Yang Jiao <[email protected]>
Co-authored-by: stonezdj(Daojun Zhang) <[email protected]>
Co-authored-by: stonezdj <[email protected]>
Co-authored-by: Wang Yan <[email protected]>
Co-authored-by: ShengqiWang <[email protected]>
altynbaev pushed a commit to altynbaev/harbor that referenced this pull request Jan 29, 2024
fixes goharbor#19429

Signed-off-by: stonezdj <[email protected]>
Co-authored-by: stonezdj <[email protected]>
Signed-off-by: Altynbaev Dinislam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy cache serves the stale digests for the latest tags
6 participants