-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to distribution (registry) v3 alpha #19784
Upgrade to distribution (registry) v3 alpha #19784
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## distribution_v3_test #19784 +/- ##
=========================================================
- Coverage 70.63% 45.25% -25.39%
=========================================================
Files 747 244 -503
Lines 95833 13332 -82501
Branches 0 2720 +2720
=========================================================
- Hits 67696 6033 -61663
+ Misses 24469 6998 -17471
+ Partials 3668 301 -3367
Flags with carried forward coverage won't be shown. Click here to find out more.
|
thanks @AaronDewes , I'm considering using a separate branch for your changes. This approach allows us to conduct thorough testing to prevent any potential regressions. |
9d8ff1d
to
04e52b0
Compare
Hi @AaronDewes , Thanks for your contribution! Would you mind changing the merge branch from main to distribution_v3_test. We would like to do regression test based on this branch |
Sure, I'll also rebase this later. |
04e52b0
to
38693fb
Compare
The files that depend on |
Signed-off-by: Lars Lehtonen <[email protected]>
Signed-off-by: Yang Jiao <[email protected]> Co-authored-by: Yang Jiao <[email protected]>
fixes goharbor#19429 Signed-off-by: stonezdj <[email protected]> Co-authored-by: stonezdj <[email protected]>
Signed-off-by: Yang Jiao <[email protected]> Co-authored-by: Yang Jiao <[email protected]>
remove the unused the part from makefile Signed-off-by: wang yan <[email protected]>
e3bd47e
to
0f60ada
Compare
Signed-off-by: Yang Jiao <[email protected]>
As for the separate branch, we can proceed by merging the PR and then focus on regression testing. If any issues are identified during testing, we can address them promptly. Additionally, there may be a need to contribute the changes upstream. @MinerYang Im OK to merge it if the CI passes, and start the regression testing. |
* fix artifact page bug * update testcase
This includes all the benefits of the v3 distribution, but also all breaking changes. Most notably, Image Manifest v2 Schema v1 support has been dropped, as well as the `oss` and `swift` storage drivers. Currently, this still relies on v2's github.com/docker/distribution/registry/client/auth/challenge, because that code has been removed from the public API in v3. Signed-off-by: Aaron Dewes <[email protected]>
fa295d4
to
55de925
Compare
@wy65701436 I fixed the build failures, but DCO fails now after I rebased on master. Can you merge master into distribution_v3_test first, so the DCO bot passes? And the CI requires another approval because I pushed a commit and I'm a first time contributor. |
Hi @AaronDewes , |
@MinerYang My commit is signed off. The problem is that this PR contains commits from master not yet in the |
Comprehensive Summary of your change
This includes all the benefits of the v3 distribution, but also all breaking changes.
Most notably, Image Manifest v2 Schema v1 support has been dropped, as well as the
oss
andswift
storage drivers.Currently, this still relies on v2's github.com/docker/distribution through indirect dependencies.
This PR is a draft because distribution v3 isn't stable yet. However, I am sucessfully running Harbor of this branch.
Issue being fixed
None
Please indicate you've done the following: