Support external secrets for service tokens and xsrf

[darend]

Add support for using external/existing secrets for the following keys:

• registry.secret
• jobservice.secret
• core.secret
• core.xsrfKey

[zyyw]

Thanks for contributing to harbor-helm!
Could you please justify why you would like external secrets for service tokens and xsrf?

[darend]

Could you please justify why you would like external secrets for service tokens and xsrf?

This is related to previous requests including #189 and #1179. A growing practice is to use gitops to automate deployment of charts (ie: argocd). Without external secret supports the sensitive values will need to be defined in the values file, or rely on the autogenerated helm values. Exposing in the values file is not secure. Relying on autogenerated values can lead to challenges where every run will produce new values for the secrets. This PR will address this limitation for all of the the remaining sensitive values.

[darend]

Hi @zyyw , do you have any concerns with this change?

[darend]

@zyyw I have rebased after chart museum was removed

[cdemers]

Hi! Any progress on that PR? As was said before, It would help users of ArgoCD. Especially as ArgoCD provides a valuable information regarding synchronisation status between what's deployed and what's would be deployed based on git. Having the xsrf regenerated every time we render the Helm template to check if there is drift makes it so that it's either always out of sync, or always synchronizing, which is usually not practical.
Thanks!

[cvegagimenez]

Hi @zyyw ,

any news about this?

[zyyw]

@darend sorry for troubling you. Would you mind rebasing the main branch and resolving the conflicts?

I'll create a separate PR based on this one if we haven't heard from you in one week. But credits go to you.
Thank you for contributing to harbor-helm!

[darend]

Hi @zyyw , I will work on rebasing over the next few days

[zyyw]

Sounds great!

[darend]

zyyw it has been rebased

[zyyw]

Awesome!